Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document gRPC code generation #36640

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Document gRPC code generation #36640

merged 1 commit into from
Oct 25, 2023

Conversation

cescoffier
Copy link
Member

Also:

@cescoffier cescoffier requested a review from alesj October 23, 2023 15:40
@quarkus-bot

This comment has been minimized.

Sign in to view
@cescoffier cescoffier requested a review from geoand October 24, 2023 06:17
gsmet
gsmet requested changes Oct 24, 2023
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spotted a couple of very minor things.

docs/src/main/asciidoc/grpc-generation-reference.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/grpc-generation-reference.adoc Show resolved Hide resolved
docs/src/main/asciidoc/grpc.adoc Outdated Show resolved Hide resolved
@cescoffier
Document gRPC code generation
d8fa1ca 
Also:

- Allows configuring the `proto` directory (quarkusio#12802)
- Provides Gradle snippets (quarkusio#33854)
@cescoffier cescoffier force-pushed the grpc-code-generation-improvements branch from 7c16a69 to d8fa1ca Compare October 25, 2023 06:38
@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 25, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 25, 2023

Failing Jobs - Building d8fa1ca

Status Name Step Failures Logs Raw logs Build scan
✖ JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 21
✔️ Maven Tests - JDK 11
✖ Maven Tests - JDK 11 Windows Build Failures Logs Raw logs
✖ Native Tests - Cache Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Maven Tests - JDK 11 Windows #

- Failing: integration-tests/maven

📦 integration-tests/maven

✖ io.quarkus.maven.it.DevMojoIT.testExternalReloadableArtifacts line 1448 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.DevMojoIT was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.DevMojoIT.testExternalReloadableArtifacts line 1448 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.DevMojoIT was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.JarRunnerIT.testNonAsciiDir line 70 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.maven.it.JarRunnerIT.testNonAsciiDir line 70 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

⚙️ Native Tests - Cache #

- Failing: integration-tests/infinispan-cache-jpa

📦 integration-tests/infinispan-cache-jpa

✖ Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project quarkus-integration-test-infinispan-cache-jpa: Failed to build quarkus application

@gsmet gsmet merged commit 7e19d8c into quarkusio:main Oct 25, 2023
50 of 54 checks passed
@quarkus-bot quarkus-bot bot added kind/bugfix kind/enhancement New feature or request labels Oct 25, 2023
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Oct 25, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 25, 2023
@github-actions
Copy link

🙈 The PR is closed and the preview is expired.

@cescoffier cescoffier deleted the grpc-code-generation-improvements branch October 27, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@gsmet gsmet gsmet approved these changes

@alesj alesj alesj approved these changes

Assignees
No one assigned
Labels
area/core area/documentation area/grpc gRPC kind/bugfix kind/enhancement New feature or request
Projects
Quarkus Documentation
Status: Done
Milestone
3.6.0.CR1
Development

Successfully merging this pull request may close these issues.

Quarkus gRPC guide doesn't have Gradle examples gRPC: Configurable proto input directory
4 participants
@cescoffier @alesj @gsmet @geoand