Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use container urls for connecting to services by default #36630

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Oct 23, 2023

It is better for the build cache and for local testing, nowadays, there is a good chance people will use containers anyway.

See this thread for more information.

It is better for the build cache and for local testing, nowadays, there
is a good chance people will use containers anyway.
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 23, 2023

/cc @Sanne (hibernate-orm), @yrodiere (hibernate-orm)

@yrodiere yrodiere added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 23, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 23, 2023

Failing Jobs - Building 31a70fc

Status Name Step Failures Logs Raw logs Build scan
Native Tests - Messaging1 Build Failures Logs Raw logs

Failures

⚙️ Native Tests - Messaging1 #

- Failing: integration-tests/kafka-oauth-keycloak 

📦 integration-tests/kafka-oauth-keycloak

Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project quarkus-integration-test-kafka-oauth-keycloak: Failed to build quarkus application

@gsmet gsmet merged commit 804a2d0 into quarkusio:main Oct 24, 2023
29 of 30 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Oct 24, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants