Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix termination of the fallback virtual thread executor #36624

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

cescoffier
Copy link
Member

Otherwise, a few tests are waiting 1min to complete.

@gsmet it might to the extended CI build time.

@cescoffier cescoffier requested a review from ozangunalp October 23, 2023 08:20
@quarkus-bot quarkus-bot bot added the area/virtual-threads Issue related to Java's Virtual Threads label Oct 23, 2023
@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 23, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 23, 2023

Failing Jobs - Building cdfc1d1

Status Name Step Failures Logs Raw logs Build scan
✔️ Gradle Tests - JDK 11
Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 17 Build Failures Logs Raw logs
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs
JVM Tests - JDK 20 Build Failures Logs Raw logs
✔️ Maven Tests - JDK 11
Maven Tests - JDK 11 Windows Build Failures Logs Raw logs
Native Tests - Messaging1 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.builder.QuarkusModelBuilderTest.shouldLoadMultiModuleDevModel line 100 - More details - Source on GitHub

org.gradle.tooling.BuildException: Could not run build action using connection to Gradle distribution 'https://services.gradle.org/distributions/gradle-8.4-bin.zip'.
	at org.gradle.tooling.internal.consumer.ExceptionTransformer.transform(ExceptionTransformer.java:51)
	at org.gradle.tooling.internal.consumer.ExceptionTransformer.transform(ExceptionTransformer.java:29)

io.quarkus.gradle.builder.QuarkusModelBuilderTest.shouldLoadMultiModuleTestModel line 66 - More details - Source on GitHub

org.gradle.tooling.BuildException: Could not run build action using connection to Gradle distribution 'https://services.gradle.org/distributions/gradle-8.4-bin.zip'.
	at org.gradle.tooling.internal.consumer.ExceptionTransformer.transform(ExceptionTransformer.java:51)
	at org.gradle.tooling.internal.consumer.ExceptionTransformer.transform(ExceptionTransformer.java:29)

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/oidc-client-graphql/deployment 

📦 extensions/oidc-client-graphql/deployment

io.quarkus.oidc.client.graphql.GraphQLClientUsingOidcClientTest.dynamicClientWithDefault line 58 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/vertx-http/deployment 
! Skipped: devtools/cli extensions/agroal/deployment extensions/amazon-lambda-http/deployment and 364 more

📦 extensions/vertx-http/deployment

io.quarkus.vertx.http.proxy.TrustedForwarderProxyFailureTest.testHeadersAreIgnored line 29 - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/sun.nio.ch.NioSocketImpl.timedRead(NioSocketImpl.java:288)
	at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:314)

⚙️ JVM Tests - JDK 20 #

- Failing: extensions/oidc-client-graphql/deployment 

📦 extensions/oidc-client-graphql/deployment

io.quarkus.oidc.client.graphql.GraphQLClientUsingOidcClientTest.dynamicClientWithDefault line 58 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

⚙️ Maven Tests - JDK 11 Windows #

- Failing: integration-tests/maven 

📦 integration-tests/maven

io.quarkus.maven.it.DevMojoIT.testExternalReloadableArtifacts line 1448 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.DevMojoIT was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

io.quarkus.maven.it.DevMojoIT.testExternalReloadableArtifacts line 1448 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.DevMojoIT was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

io.quarkus.maven.it.JarRunnerIT.testNonAsciiDir line 70 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

io.quarkus.maven.it.JarRunnerIT.testNonAsciiDir line 70 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

⚙️ Native Tests - Messaging1 #

- Failing: integration-tests/kafka-oauth-keycloak 

📦 integration-tests/kafka-oauth-keycloak

Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project quarkus-integration-test-kafka-oauth-keycloak: Failed to build quarkus application

@cescoffier cescoffier merged commit dae63b5 into quarkusio:main Oct 23, 2023
45 of 51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Oct 23, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 23, 2023
@cescoffier cescoffier deleted the fix-fallback-virtual-executor branch October 25, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/virtual-threads Issue related to Java's Virtual Threads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants