Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OIDC/GraphQL client initialization #36623

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

jmartisk
Copy link
Contributor

@jmartisk jmartisk commented Oct 23, 2023

  • make sure GraphQL client config is enhanced with OIDC stuff AFTER we're sure that the GraphQL client configs already exist
  • get rid of config merger bean (it's not necessary to keep it as a CDI bean when its only purpose is to do one thing at boot)

This "should" fix intermittent failures of GraphQLClientUsingOidcClientTest, I hope...

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 23, 2023

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not end up with ellipsis (make sure the title is complete)

This message is automatically generated by a bot.

@jmartisk jmartisk changed the title Make sure OIDC/GraphQL client integration runs after client config is… Fix OIDC/GraphQL client initialization Oct 23, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 23, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@sberyozkin sberyozkin self-requested a review October 23, 2023 09:00
Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are green, hopefully it well help to stabilize 👍

@sberyozkin sberyozkin merged commit 4fb9864 into quarkusio:main Oct 23, 2023
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Oct 23, 2023
@jmartisk jmartisk deleted the graphql-client-oidc-optimize branch October 23, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants