Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts workaround liquibase issue #36606

Merged

Conversation

appiepollo14
Copy link
Contributor

@appiepollo14 appiepollo14 commented Oct 20, 2023

liquibase/liquibase#4763 is solved since we've updated to liquibase 4.24.0

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 20, 2023

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not end up with ellipsis (make sure the title is complete)

This message is automatically generated by a bot.

@appiepollo14 appiepollo14 changed the title Reverts changes made to workaround liquibase issue: https://github.co… Reverts workaround liquibase issue Oct 20, 2023
@appiepollo14 appiepollo14 force-pushed the feature/revert-liquibase-workaround-4.23.1 branch from 04590cf to 7104be7 Compare October 21, 2023 17:38
@appiepollo14 appiepollo14 force-pushed the feature/revert-liquibase-workaround-4.23.1 branch from 7104be7 to d0f28ac Compare October 23, 2023 05:38
@gsmet gsmet requested a review from famod October 23, 2023 08:06
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 23, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet gsmet merged commit a719ec8 into quarkusio:main Oct 24, 2023
19 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Oct 24, 2023
@appiepollo14 appiepollo14 deleted the feature/revert-liquibase-workaround-4.23.1 branch October 24, 2023 15:09
@famod
Copy link
Member

famod commented Nov 2, 2023

FWIW, I just checked this change on top of 3.5.0 and there is no regression (as expected).
Thanks @appiepollo14!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants