Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move quarkus-jaeger and quarkus-smallrye-opentracing to Quarkiverse #36602

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Oct 20, 2023

Fixes #35984
Fixes #35985

@brunobat how do you envision the Quarkiverse extensions? Should I create two separate repositories or do we move the two extensions in one quarkus-smallrye-opentracing repository? Note that I don't think Jaeger had any tests on its own.

@gsmet gsmet requested a review from brunobat October 20, 2023 16:11
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/jaeger area/mongodb area/smallrye area/tracing labels Oct 20, 2023
@brunobat
Copy link
Contributor

how do you envision the Quarkiverse extensions?

I say 2 different isolated extensions.

I don't think Jaeger had any tests on its own

No integration tests, just the tests in the deployment project

@gsmet
Copy link
Member Author

gsmet commented Oct 20, 2023

OK.

@gastaldi would you be kind enough to provision quarkus-jaeger and quarkus-smallrye-opentracing repositories in the Quarkiverse with me and @brunobat as maintainers?

@gastaldi
Copy link
Contributor

@gastaldi would you be kind enough to provision quarkus-jaeger and quarkus-smallrye-opentracing repositories in the Quarkiverse with me and @brunobat as maintainers?

Sure, there you go: quarkiverse/quarkiverse-devops#186

@gsmet
Copy link
Member Author

gsmet commented Oct 26, 2023

I'm back working on this.

@brunobat
Copy link
Contributor

I'm finally writing the OpenTracing to OpenTelemetry guide @gsmet.

@gsmet
Copy link
Member Author

gsmet commented Oct 26, 2023

Cool, looks like the stars will be aligned :).

Copy link

github-actions bot commented Nov 9, 2023

🙈 The PR is closed and the preview is expired.

@gsmet gsmet force-pushed the jaeger-opentracing branch from 7b7514e to dfa4be5 Compare November 10, 2023 10:39
@gsmet gsmet marked this pull request as ready for review November 13, 2023 10:19
@gsmet
Copy link
Member Author

gsmet commented Nov 13, 2023

@brunobat this is now ready, just in time for 3.6.0.CR1 if we can get it merged by tomorrow. I will release the Quarkiverse artifacts once 3.6.0 core artifacts are out so that they are only compatible with 3.6+ and don't appear in 3.5 code.quarkus.io.

@brunobat
Copy link
Contributor

brunobat commented Nov 13, 2023

@gsmet The failures seem unrelated but they are failing with:

2023-11-13T16:32:01.4250160Z Caused by: org.apache.maven.surefire.booter.SurefireBooterForkException: There was an error in the forked process
2023-11-13T16:32:01.4251226Z Metaspace
2023-11-13T16:32:01.4251779Z java.lang.OutOfMemoryError: Metaspace

Copy link
Contributor

@brunobat brunobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.
There are some references on the datasource.adoc to OpenTracing but I'll take care later.
Thanks very much for the help on this @gsmet

Copy link

quarkus-bot bot commented Nov 13, 2023

Failing Jobs - Building dfa4be5

Status Name Step Failures Logs Raw logs Build scan
✔️ Gradle Tests - JDK 11
Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 21
Native Tests - Data1 Build Failures Logs Raw logs
Quickstarts Compilation - JDK 17 Compile Quickstarts Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.CustomManifestArgumentsTest.shouldContainsSpecificManifestProperty line 37 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual not to be null

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/hibernate-orm/deployment 
! Skipped: extensions/flyway/deployment extensions/hibernate-envers/deployment extensions/hibernate-reactive/deployment and 87 more

📦 extensions/hibernate-orm/deployment

Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.1.2:test (default-test) on project quarkus-hibernate-orm-deployment:

Please refer to /home/runner/work/quarkus/quarkus/extensions/hibernate-orm/deployment/target/surefire-reports for the individual test results.
Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
There was an error in the forked process


⚙️ Native Tests - Data1 #

- Failing: integration-tests/jpa-mssql 

📦 integration-tests/jpa-mssql

Failed to execute goal io.fabric8:docker-maven-plugin:0.43.4:start (docker-start) on project quarkus-integration-test-jpa-mssql: I/O Error


⚙️ Quickstarts Compilation - JDK 17 #

- Failing: opentracing-quickstart 

📦 opentracing-quickstart

Failed to execute goal on project opentracing-quickstart: Could not resolve dependencies for project org.acme:opentracing-quickstart:jar:1.0.0-SNAPSHOT: Could not find artifact io.quarkiverse.opentracing:quarkus-smallrye-opentracing:jar:1.0.0 in google-maven-central (https://maven-central.storage-download.googleapis.com/maven2/)

@michalvavrik
Copy link
Member

@gsmet this is breaking change (at least it broke QE app), would breaking label fit here?

@michalvavrik
Copy link
Member

Hmm, I can see it in a migration guide https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.6 - maybe the flow doesn't require the label, I don't know.

@brunobat
Copy link
Contributor

@michalvavrik I also wrote this: https://quarkus.io/version/main/guides/telemetry-opentracing-to-otel-tutorial
I hope it helps. Will add it to the migration guide.

@michalvavrik
Copy link
Member

@michalvavrik I also wrote this: https://quarkus.io/version/main/guides/telemetry-opentracing-to-otel-tutorial I hope it helps. Will add it to the migration guide.

thank you

@gsmet
Copy link
Member Author

gsmet commented Nov 15, 2023

@michalvavrik yeah, you're right, I added the appropriate labels. Thanks for your vigilance!

gsmet pushed a commit to gsmet/quarkus that referenced this pull request Nov 17, 2023
computerlove pushed a commit to computerlove/quarkus that referenced this pull request Nov 27, 2023
DavideD pushed a commit to DavideD/quarkus that referenced this pull request Nov 27, 2023
holly-cummins pushed a commit to holly-cummins/quarkus that referenced this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5 participants