-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move quarkus-jaeger and quarkus-smallrye-opentracing to Quarkiverse #36602
Conversation
I say 2 different isolated extensions.
No integration tests, just the tests in the |
Sure, there you go: quarkiverse/quarkiverse-devops#186 |
I'm back working on this. |
I'm finally writing the OpenTracing to OpenTelemetry guide @gsmet. |
Cool, looks like the stars will be aligned :). |
c5a0ddb
to
07fe697
Compare
07fe697
to
d48e334
Compare
🙈 The PR is closed and the preview is expired. |
7b7514e
to
dfa4be5
Compare
@brunobat this is now ready, just in time for 3.6.0.CR1 if we can get it merged by tomorrow. I will release the Quarkiverse artifacts once 3.6.0 core artifacts are out so that they are only compatible with 3.6+ and don't appear in 3.5 code.quarkus.io. |
@gsmet The failures seem unrelated but they are failing with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me.
There are some references on the datasource.adoc to OpenTracing but I'll take care later.
Thanks very much for the help on this @gsmet
Failing Jobs - Building dfa4be5
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
⚙️ JVM Tests - JDK 11 #- Failing: extensions/hibernate-orm/deployment
! Skipped: extensions/flyway/deployment extensions/hibernate-envers/deployment extensions/hibernate-reactive/deployment and 87 more 📦 extensions/hibernate-orm/deployment✖
⚙️ Native Tests - Data1 #- Failing: integration-tests/jpa-mssql
📦 integration-tests/jpa-mssql✖ ⚙️ Quickstarts Compilation - JDK 17 #- Failing: opentracing-quickstart
📦 opentracing-quickstart✖ |
The test was removed in quarkusio#36602
@gsmet this is breaking change (at least it broke QE app), would breaking label fit here? |
Hmm, I can see it in a migration guide https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.6 - maybe the flow doesn't require the label, I don't know. |
@michalvavrik I also wrote this: https://quarkus.io/version/main/guides/telemetry-opentracing-to-otel-tutorial |
thank you |
@michalvavrik yeah, you're right, I added the appropriate labels. Thanks for your vigilance! |
The test was removed in quarkusio#36602 (cherry picked from commit f63d7b5)
The test was removed in quarkusio#36602
The test was removed in quarkusio#36602
The test was removed in quarkusio#36602
Fixes #35984
Fixes #35985
@brunobat how do you envision the Quarkiverse extensions? Should I create two separate repositories or do we move the two extensions in one
quarkus-smallrye-opentracing
repository? Note that I don't think Jaeger had any tests on its own.