Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about new sponsor field #36579

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

holly-cummins
Copy link
Contributor

See https://quarkus.io/extensions/io.quarkiverse.mailpit/quarkus-mailpit of an extension using this field (and how we render it in the extensions UI).

See https://groups.google.com/g/quarkus-dev/c/ez3d5MqNm7k/m/VKW78oSVAwAJ for a longer discussion of the rules for what we show where and how to control it. Including all of this information in the extension metadata docs doesn't seem right, so I will include some of it in the quarkiverse hub pages, and some of it in the readme for the extension catalog. I may also write a blog. I will also include it next to the contributors graphs in the extensions UI, and, once I implement it, in hover help in the UI for the sponsors field.

@gastaldi
Copy link
Contributor

Dumb question, but would it make sense to have the Sponsor field as a link to the sponsor homepage?

@holly-cummins
Copy link
Contributor Author

Dumb question, but would it make sense to have the Sponsor field as a link to the sponsor homepage?

Good point! I've done that for users on the user graph (although it will take a few days to work through the caches), and it makes sense to extend it to sponsors. For companies on the company graph, and sponsors where we derive it from GitHub I can read the URL from the GitHub data, but when the sponsor is set via in the metadata, it's a bit harder. In most cases I could cross-reference against employees, but I can see that for https://quarkus.io/extensions/io.quarkiverse.mailpit/quarkus-mailpit, the employer affiliation of the contributing people doesn't line up neatly with the named sponsor, so I'd be a bit stuck.

So I guess maybe we'd have to add (and document) an extra field. I'm a bit reluctant to overwhelm the docs with fields, though. Hmm.

@github-actions
Copy link

github-actions bot commented Oct 19, 2023

🙈 The PR is closed and the preview is expired.

@gsmet
Copy link
Member

gsmet commented Oct 24, 2023

@holly-cummins do you want us to merge this or do you plan more work on it?

@holly-cummins
Copy link
Contributor Author

I think it's good to merge, please, @gsmet. I'm going to think about links to homepages, but that would be a separate piece of work, and then extra documentation.

@gsmet gsmet merged commit 80e8687 into quarkusio:main Oct 24, 2023
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Oct 24, 2023
@gsmet
Copy link
Member

gsmet commented Oct 24, 2023

Merged, thanks for the quick feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants