-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module build duration report #36574
Module build duration report #36574
Conversation
/cc @brunobat (opentelemetry), @radcortez (opentelemetry) |
36bc436
to
959d571
Compare
@azthec thanks! I pushed an additional commit to your branch as I needed some additional features. Please have a look and make sure you update your local branch with this commit before pushing. |
@azthec I pushed some additional improvements/fixes and pushed another commit. Could you have a look at the commits and tell me if it looks good for you? If so, we can probably merge it (and improve it further if needed). |
(I did it myself as I needed the script right away to try to understand a failing build) |
I should have some time tomorrow to polish this PR, good that it's useful! Let me know if you find any edge cases not in the TODO comments |
OK, I will let you have a look at what I did. I think it's pretty much done now but better have another pair of eyes :) |
I changed the format of the module names a bit
What do you think? |
2cee0db
to
19edbc2
Compare
@@ -39,7 +39,7 @@ public class ModuleBuildDurationReport implements Runnable { | |||
|
|||
// we will assume the previous module ends on this and a new one begins | |||
private static final Pattern BUILD_START_PATTERN = | |||
Pattern.compile("^" + TIMESTAMP + " \\[INFO\\] Building (.+?) (\\S+-SNAPSHOT).* \\[([0-9]+)/[0-9]+\\]"); | |||
Pattern.compile("^" + TIMESTAMP + " \\[INFO\\] Building Quarkus - (.+?) (\\S+-SNAPSHOT).* \\[([0-9]+)/[0-9]+\\]"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed that myself because actually not every module starts with Quarkus -
. Things in independent-projects/
usually don't so we are missing some modules if you do that.
e9a7ce9
to
459bc42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cleaned up the history a bit to avoid having merge commits.
Thanks for your contribution!
Implementing #36449
Adds a cli jbang script to quickly print out a table of module build times.
I picked a couple of random logs for the example.
Example output
Example 1
Log
Program
36.606s - 34.142s = 02.462s (rounding) correct
Example 2
Log
Program
43.504 - 43.265 = .239s (rounding) correct