Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump apicurio-registry.version from 2.4.7.Final to 2.4.13.Final #36565

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Bump apicurio-registry.version from 2.4.7.Final to 2.4.13.Final #36565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33b5e2d
Bump apicurio-registry.version from 2.4.7.Final to 2.4.14.Final
dependabot[bot] Oct 18, 2023
9e7b2c1
Kafka Confluent avro schema serializer doc update
ozangunalp Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bom/application/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@
<log4j2-api.version>2.20.0</log4j2-api.version>
<log4j-jboss-logmanager.version>1.3.0.Final</log4j-jboss-logmanager.version>
<avro.version>1.11.3</avro.version>
<apicurio-registry.version>2.4.7.Final</apicurio-registry.version>
<apicurio-registry.version>2.4.14.Final</apicurio-registry.version>
<apicurio-common-rest-client.version>0.1.18.Final</apicurio-common-rest-client.version> <!-- must be the version Apicurio Registry uses -->
<testcontainers.version>1.19.1</testcontainers.version> <!-- Make sure to also update docker-java.version to match its needs -->
<docker-java.version>3.3.3</docker-java.version> <!-- must be the version Testcontainers use -->
Expand Down
23 changes: 18 additions & 5 deletions docs/src/main/asciidoc/kafka-schema-registry-avro.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -795,14 +795,27 @@
----

In JVM mode, any version of `io.confluent:kafka-avro-serializer` can be used.
In native mode, Quarkus only supports the following versions:
In native mode, Quarkus supports the following versions: `6.2.x`, `7.0.x`, `7.1.x`, `7.2.x`, `7.3.x`.

Check warning on line 798 in docs/src/main/asciidoc/kafka-schema-registry-avro.adoc

View workflow job for this annotation

GitHub Actions / Linting with Vale 

[vale] reported by reviewdog 🐶
[Quarkus.Fluff] Depending on the context, consider using 'Rewrite the sentence, or use 'must', instead of' rather than 'need to'.

Raw Output:
{"message": "[Quarkus.Fluff] Depending on the context, consider using 'Rewrite the sentence, or use 'must', instead of' rather than 'need to'.", "location": {"path": "docs/src/main/asciidoc/kafka-schema-registry-avro.adoc", "range": {"start": {"line": 798, "column": 101}}}, "severity": "INFO"}

* 6.2.x
* 7.0.x
* 7.1.x
* 7.2.x
For version `7.4.x` and `7.5.x`, due to an issue with the Confluent Schema Serializer, you need to add another dependency:

[source,xml,role="primary asciidoc-tabs-target-sync-cli asciidoc-tabs-target-sync-maven"]
.pom.xml
----
<dependency>
<groupId>com.fasterxml.jackson.dataformat</groupId>
<artifactId>jackson-dataformat-csv</artifactId>

Check warning on line 807 in docs/src/main/asciidoc/kafka-schema-registry-avro.adoc

View workflow job for this annotation

GitHub Actions / Linting with Vale 

[vale] reported by reviewdog 🐶
[Quarkus.CaseSensitiveTerms] Use 'Gradle' rather than 'gradle'.

Raw Output:
{"message": "[Quarkus.CaseSensitiveTerms] Use 'Gradle' rather than 'gradle'.", "location": {"path": "docs/src/main/asciidoc/kafka-schema-registry-avro.adoc", "range": {"start": {"line": 807, "column": 40}}}, "severity": "INFO"}
</dependency>
----
[source,gradle,role="secondary asciidoc-tabs-target-sync-gradle"]
.build.gradle
----
dependencies {
implementation("com.fasterxml.jackson.dataformat:jackson-dataformat-csv")

Check warning on line 814 in docs/src/main/asciidoc/kafka-schema-registry-avro.adoc

View workflow job for this annotation

GitHub Actions / Linting with Vale 

[vale] reported by reviewdog 🐶
[Quarkus.Spelling] Use correct American English spelling. Did you really mean 'Avro'?

Raw Output:
{"message": "[Quarkus.Spelling] Use correct American English spelling. Did you really mean 'Avro'?", "location": {"path": "docs/src/main/asciidoc/kafka-schema-registry-avro.adoc", "range": {"start": {"line": 814, "column": 60}}}, "severity": "WARNING"}
}
----

For any other versions, the native configuration may need to be adjusted.

Check warning on line 818 in docs/src/main/asciidoc/kafka-schema-registry-avro.adoc

View workflow job for this annotation

GitHub Actions / Linting with Vale 

[vale] reported by reviewdog 🐶
[Quarkus.TermsWarnings] Consider using 'might (for possiblity)' or 'can (for ability)' rather than 'may' unless updating existing content that uses the term.

Raw Output:
{"message": "[Quarkus.TermsWarnings] Consider using 'might (for possiblity)' or 'can (for ability)' rather than 'may' unless updating existing content that uses the term.", "location": {"path": "docs/src/main/asciidoc/kafka-schema-registry-avro.adoc", "range": {"start": {"line": 818, "column": 50}}}, "severity": "WARNING"}

Check warning on line 818 in docs/src/main/asciidoc/kafka-schema-registry-avro.adoc

View workflow job for this annotation

GitHub Actions / Linting with Vale 

[vale] reported by reviewdog 🐶
[Quarkus.Fluff] Depending on the context, consider using 'Rewrite the sentence, or use 'must', instead of' rather than 'need to'.

Raw Output:
{"message": "[Quarkus.Fluff] Depending on the context, consider using 'Rewrite the sentence, or use 'must', instead of' rather than 'need to'.", "location": {"path": "docs/src/main/asciidoc/kafka-schema-registry-avro.adoc", "range": {"start": {"line": 818, "column": 54}}}, "severity": "INFO"}

== Avro code generation details

Expand Down
6 changes: 5 additions & 1 deletion integration-tests/kafka-avro-apicurio2/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,14 +57,18 @@
<dependency>
<groupId>io.confluent</groupId>
<artifactId>kafka-avro-serializer</artifactId>
<version>7.2.1</version>
<version>7.5.1</version>
<exclusions>
<exclusion>
<groupId>org.checkerframework</groupId>
<artifactId>checker-qual</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.dataformat</groupId>
<artifactId>jackson-dataformat-csv</artifactId>
</dependency>
<!-- Apicurio & Confluent -->
<dependency>
<groupId>io.quarkus</groupId>
Expand Down
Loading