-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow default exporter with additional Quarkiverse exporters #36552
base: main
Are you sure you want to change the base?
Conversation
/cc @brunobat (opentelemetry), @radcortez (opentelemetry) |
...java/io/quarkus/opentelemetry/runtime/config/runtime/exporter/OtlpExporterRuntimeConfig.java
Show resolved
Hide resolved
5db75e3
to
c2db003
Compare
I've done the changes you suggested |
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
@azthec We need integration tests. I actually have an integration test project for this but I need the next version of Quarkus and the Quarkiverse exporters to be released. Let's come back to this then, I'll push a commit to your branch when the time comes. |
@brunobat Hello, is this still needed or can the PR be closed? |
I think it's a valuable feature, But we need tests. |
Would this be a different task that is blocked / ongoing? |
No, there not another issue about this. |
@brunobat Where are we on this one? |
It makes sense, but it still needs IT tests. |
@azthec could you rebase and add ITs? |
@azthec Will you still be working on this? |
#36500 Currently, when custom exporters are present the default exporter is not instantiated, this provides a configuration to always do so.