Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow default exporter with additional Quarkiverse exporters #36552

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

azthec
Copy link
Contributor

@azthec azthec commented Oct 18, 2023

#36500 Currently, when custom exporters are present the default exporter is not instantiated, this provides a configuration to always do so.

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 18, 2023

/cc @brunobat (opentelemetry), @radcortez (opentelemetry)

@azthec azthec force-pushed the default-exporter-enable-conf branch from 5db75e3 to c2db003 Compare October 18, 2023 21:27
@azthec azthec requested a review from brunobat October 18, 2023 21:27
@azthec
Copy link
Contributor Author

azthec commented Oct 18, 2023

I've done the changes you suggested

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 19, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@brunobat
Copy link
Contributor

@azthec We need integration tests. I actually have an integration test project for this but I need the next version of Quarkus and the Quarkiverse exporters to be released. Let's come back to this then, I'll push a commit to your branch when the time comes.

@azthec
Copy link
Contributor Author

azthec commented May 16, 2024

@brunobat Hello, is this still needed or can the PR be closed?

@brunobat
Copy link
Contributor

I think it's a valuable feature, But we need tests.

@azthec
Copy link
Contributor Author

azthec commented May 16, 2024

Would this be a different task that is blocked / ongoing?

@brunobat
Copy link
Contributor

No, there not another issue about this.

@cescoffier
Copy link
Member

@brunobat Where are we on this one?

@brunobat
Copy link
Contributor

brunobat commented Nov 11, 2024

It makes sense, but it still needs IT tests.

@cescoffier
Copy link
Member

@azthec could you rebase and add ITs?

@brunobat
Copy link
Contributor

brunobat commented Jan 7, 2025

@azthec Will you still be working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants