-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create security cors doc #36541
Create security cors doc #36541
Conversation
🙈 The PR is closed and the preview is expired. |
9807857
to
d7b4dd8
Compare
This comment has been minimized.
This comment has been minimized.
@sberyozkin do you know why the preview deploy failed? Asking because want to check how the guide is presented on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
References will need to be updated in more places:
git grep -l "#cors-filter"
docs/src/main/asciidoc/openapi-swaggerui.adoc
docs/src/main/asciidoc/resteasy-reactive.adoc
docs/src/main/asciidoc/resteasy.adoc
docs/src/main/asciidoc/security-csrf-prevention.adoc
docs/src/main/asciidoc/security-oidc-bearer-token-authentication.adoc
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
docs/src/main/asciidoc/security-overview.adoc
/cc @mjurc (qe) |
Sorry, @rsvoboda, I was under impression only one doc was referring to the HTTP CORS section, thanks for reminding all docs have to be checked (those links would still work since HTTP section is still there, the only problem, users will need to click on another link from there, so yes, let me handle these links) |
c96a457
to
758e8e6
Compare
@rsvoboda This is done, note |
Not sure though why surge is failing to publish |
https://quarkus-pr-main-36541-preview.surge.sh/version/main/guides/ reports Unavailable First line of the guide is shown on /guides page. This CORS guide has quite long first sentence, that's why it would be good to check it. @gastaldi @gsmet did you notice troubles with surge.sh recently? |
758e8e6
to
e1cf334
Compare
It was immediately starting from a link to the Mozilla docs, so I removed it, may be it will help for surge to succeed |
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
@rsvoboda surge did not publish again, not sure why, shall we merge it if you are otherwise happy ? I'd not mind the Doc team having a quick look though |
@sunayna15 can you have somebody from the team to look into this? We may merge it soon, docs feedback can be addressed in separate pull request. |
@rsvoboda @sberyozkin @sunayna15 Let me have a look on this content. Will create a new PR if needed. |
Thanks @rsvoboda @MichalMaler |
Fixes #36509.
This PR promotes the CORS related section as an independent security concept, linked to from both HTTP reference and Security overview docs