Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade H2 to version 2.2.224 #36540

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Upgrade H2 to version 2.2.224 #36540

merged 1 commit into from
Oct 18, 2023

Conversation

sguilhen
Copy link
Contributor

Version 2.2.220 has data corruption issues, which were addressed in version 2.2.222. That version ended up introducing performance issues (as seen in the release notes), which were fixed in 2.2.224.

In Keycloak we are also upgrading H2 as some users have reported issues that might be related to the issues in 2.2.220.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE labels Oct 17, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 17, 2023

/cc @Sanne (hibernate-orm), @gsmet (hibernate-orm), @yrodiere (hibernate-orm)

@sguilhen sguilhen mentioned this pull request Oct 17, 2023
Merged
yrodiere
yrodiere reviewed Oct 18, 2023
View reviewed changes
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I looked at Hibernate ORM and it seems it's getting tested against H2 2.2.220, so I'm not entirely sure it's compatible. I'll run some tests locally.

yrodiere
yrodiere approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@yrodiere yrodiere left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran a full build of Hibernate ORM against H2 2.2.224 locally and all tests passed.

I also opened hibernate/hibernate-orm#7454 to upgrade H2 in Hibernate ORM's main branch.

@yrodiere yrodiere added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 18, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 18, 2023

Failing Jobs - Building 181ef34

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
✖ JVM Tests - JDK 17 Windows Build Failures Logs Raw logs
✖ JVM Tests - JDK 20 Build Failures Logs Raw logs
✔️ Maven Tests - JDK 11
✖ Maven Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/vertx/deployment 
! Skipped: devtools/cli extensions/agroal/deployment extensions/amazon-lambda-http/deployment and 383 more

📦 extensions/vertx/deployment

✖ io.quarkus.vertx.mdc.VertxMDCTest.mdc line 75 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.vertx.mdc.VertxMDCTest was not fulfilled within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.vertx.mdc.VertxMDCTest.mdc line 75 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.vertx.mdc.VertxMDCTest was not fulfilled within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.vertx.mdc.VertxMDCTest.mdc line 75 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.vertx.mdc.VertxMDCTest was not fulfilled within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.vertx.mdc.VertxMDCTest.mdc line 75 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.vertx.mdc.VertxMDCTest was not fulfilled within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.vertx.mdc.VertxMDCTest.mdc line 75 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.vertx.mdc.VertxMDCTest was not fulfilled within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.vertx.mdc.VertxMDCTest.mdc line 75 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.vertx.mdc.VertxMDCTest was not fulfilled within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.vertx.mdc.VertxMDCTest.mdc line 75 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.vertx.mdc.VertxMDCTest was not fulfilled within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.vertx.mdc.VertxMDCTest.mdc line 75 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.vertx.mdc.VertxMDCTest was not fulfilled within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.vertx.mdc.VertxMDCTest.mdc line 75 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.vertx.mdc.VertxMDCTest was not fulfilled within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.vertx.mdc.VertxMDCTest.mdc line 75 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.vertx.mdc.VertxMDCTest was not fulfilled within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.vertx.mdc.VertxMDCTest.mdcNonVertxThreadTest line 119 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.vertx.mdc.VertxMDCTest was not fulfilled within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.vertx.mdc.VertxMDCTest.mdcNonVertxThreadTest line 119 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.vertx.mdc.VertxMDCTest was not fulfilled within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.vertx.mdc.VertxMDCTest.mdcNonVertxThreadTest line 119 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.vertx.mdc.VertxMDCTest was not fulfilled within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.vertx.mdc.VertxMDCTest.mdcNonVertxThreadTest line 119 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.vertx.mdc.VertxMDCTest was not fulfilled within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.vertx.mdc.VertxMDCTest.mdcNonVertxThreadTest line 119 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.vertx.mdc.VertxMDCTest was not fulfilled within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.vertx.mdc.VertxMDCTest.mdcNonVertxThreadTest line 119 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.vertx.mdc.VertxMDCTest was not fulfilled within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.vertx.mdc.VertxMDCTest.mdcNonVertxThreadTest line 119 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.vertx.mdc.VertxMDCTest was not fulfilled within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.vertx.mdc.VertxMDCTest.mdcNonVertxThreadTest line 119 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.vertx.mdc.VertxMDCTest was not fulfilled within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.vertx.mdc.VertxMDCTest.mdcNonVertxThreadTest line 119 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.vertx.mdc.VertxMDCTest was not fulfilled within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.vertx.mdc.VertxMDCTest.mdcNonVertxThreadTest line 119 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.vertx.mdc.VertxMDCTest was not fulfilled within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

⚙️ JVM Tests - JDK 20 #

📦 integration-tests/virtual-threads/grpc-virtual-threads

✖ io.quarkus.grpc.example.streaming.VertxVirtualThreadTest.testEmpty - More details - Source on GitHub

io.grpc.StatusRuntimeException: UNKNOWN: java.lang.AssertionError - Thread Thread[#141,executor-thread-4,5,main] is not a virtual thread
	at io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:275)
	at io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:256)

✖ io.quarkus.grpc.example.streaming.VertxVirtualThreadTest.testGrpcClient - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

✖ io.quarkus.grpc.example.streaming.VertxVirtualThreadTest.testStreamingOutputCall - More details - Source on GitHub

io.grpc.StatusRuntimeException: UNKNOWN: java.lang.AssertionError - Thread Thread[#128,executor-thread-1,5,main] is not a virtual thread
	at io.grpc.Status.asRuntimeException(Status.java:537)
	at io.grpc.stub.ClientCalls$BlockingResponseStream.hasNext(ClientCalls.java:666)

✖ io.quarkus.grpc.example.streaming.VertxVirtualThreadTest.testUnary - More details - Source on GitHub

io.grpc.StatusRuntimeException: UNKNOWN: java.lang.AssertionError - Thread Thread[#128,executor-thread-1,5,main] is not a virtual thread
	at io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:275)
	at io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:256)

✖ io.quarkus.grpc.example.streaming.VirtualThreadTest.testEmpty - More details - Source on GitHub

io.grpc.StatusRuntimeException: UNKNOWN: java.lang.AssertionError - Thread Thread[#70,executor-thread-1,5,main] is not a virtual thread
	at io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:275)
	at io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:256)

✖ io.quarkus.grpc.example.streaming.VirtualThreadTest.testGrpcClient - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

✖ io.quarkus.grpc.example.streaming.VirtualThreadTest.testStreamingOutputCall - More details - Source on GitHub

io.grpc.StatusRuntimeException: UNKNOWN: java.lang.AssertionError - Thread Thread[#70,executor-thread-1,5,main] is not a virtual thread
	at io.grpc.Status.asRuntimeException(Status.java:537)
	at io.grpc.stub.ClientCalls$BlockingResponseStream.hasNext(ClientCalls.java:666)

✖ io.quarkus.grpc.example.streaming.VirtualThreadTest.testUnary - More details - Source on GitHub

io.grpc.StatusRuntimeException: UNKNOWN: java.lang.AssertionError - Thread Thread[#70,executor-thread-1,5,main] is not a virtual thread
	at io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:275)
	at io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:256)

📦 integration-tests/virtual-threads/kafka-virtual-threads

✖ io.quarkus.it.vthreads.kafka.VirtualThreadTest.testAlert line 30 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a io.quarkus.it.vthreads.kafka.VirtualThreadTest Expected at least one request matching: {
  "urlPath" : "/price/alert",

✖ io.quarkus.it.vthreads.kafka.VirtualThreadTest.testAlertMessage line 36 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a io.quarkus.it.vthreads.kafka.VirtualThreadTest Expected at least one request matching: {
  "urlPath" : "/price/alert-message",

📦 integration-tests/virtual-threads/mailer-virtual-threads

✖ io.quarkus.virtual.mail.RunOnVirtualThreadTest.test line 26 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

✖ io.quarkus.virtual.mail.RunOnVirtualThreadTest.testWithTemplate line 40 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

📦 integration-tests/virtual-threads/redis-virtual-threads

✖ io.quarkus.virtual.redis.RunOnVirtualThreadTest.test line 21 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

📦 integration-tests/virtual-threads/rest-client-reactive-virtual-threads

✖ io.quarkus.virtual.rest.RunOnVirtualThreadTest.test line 20 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

📦 integration-tests/virtual-threads/resteasy-reactive-virtual-threads

✖ io.quarkus.virtual.rr.RunOnVirtualThreadTest.testFilters line 91 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

✖ io.quarkus.virtual.rr.RunOnVirtualThreadTest.testGet line 22 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

✖ io.quarkus.virtual.rr.RunOnVirtualThreadTest.testPost line 37 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

✖ io.quarkus.virtual.rr.RunOnVirtualThreadTest.testRunOnVirtualThreadOnClass line 73 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

⚙️ Maven Tests - JDK 11 Windows #

- Failing: integration-tests/maven

📦 integration-tests/maven

✖ io.quarkus.maven.it.DevMojoIT.testExternalReloadableArtifacts line 1448 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.DevMojoIT was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.DevMojoIT.testExternalReloadableArtifacts line 1448 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.DevMojoIT was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.JarRunnerIT.testNonAsciiDir line 70 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.maven.it.JarRunnerIT.testNonAsciiDir line 70 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

@yrodiere
Copy link
Member

I think all the failures are from flaky tests.

@gsmet gsmet merged commit c0bacff into quarkusio:main Oct 18, 2023
48 of 51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Oct 18, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 18, 2023
@gsmet gsmet modified the milestones: 3.6 - main, 3.5.1 Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrodiere yrodiere yrodiere approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE
Projects
None yet
Milestone
3.5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@sguilhen @yrodiere @gsmet