Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qute: relax cdi/inject namespace validation #36524

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Oct 17, 2023

  • do not fail the build if a safe expression is used

- do not fail the build if a safe expression is used
@quarkus-bot quarkus-bot bot added the area/qute The template engine label Oct 17, 2023
@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@mkouba
Copy link
Contributor Author

mkouba commented Oct 17, 2023

integration-tests/virtual-threads/mailer-virtual-threads is not failing for me locally (using JDK 21).

Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 17, 2023

Failing Jobs - Building b1c1668

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 20 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 20 #

- Failing: integration-tests/virtual-threads/mailer-virtual-threads 

📦 integration-tests/virtual-threads/mailer-virtual-threads

io.quarkus.virtual.mail.RunOnVirtualThreadTest.testWithTemplate line 40 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

io.quarkus.virtual.mail.RunOnVirtualThreadTest.test line 26 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

@mkouba
Copy link
Contributor Author

mkouba commented Oct 18, 2023

The failure in Quarkus CI / JVM Tests - JDK 20 in not related to qute but some odd virtual threads configuration issue.

@mkouba mkouba merged commit 7794fc7 into quarkusio:main Oct 18, 2023
21 of 22 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/qute The template engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants