Don't emit null values from SSE #36450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because those values break Multi (as specified by Reactive Streams)
cescoffier
approved these changes
Oct 12, 2023
|
The reason I think we should fail is that the deserialization library may choose to return |
|
Furthermore, there are APIs that push a sentinel value which can be deserialized according to the schema of the real data - if we handle these values as null then with this PR the stream can be consumed - otherwise users have to resort to manually performing the deserilization. |
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
|
I forgot to mark this one for backport to 3.5 :(. Added the label now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because those values break
Multi (as specified by Reactive Streams)