-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify REST Clients extension names #36447
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no strong opinion either way, so let's do it 🙂
Definitely +1 |
Failing Jobs - Building aa26b69
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: extensions/oidc-client-graphql/deployment
📦 extensions/oidc-client-graphql/deployment✖
✖
⚙️ JVM Tests - JDK 17 #- Failing: extensions/oidc-client-graphql/deployment
📦 extensions/oidc-client-graphql/deployment✖
⚙️ JVM Tests - JDK 20 #- Failing: extensions/oidc-client-graphql/deployment
📦 extensions/oidc-client-graphql/deployment✖
|
@jmartisk this GraphQL test looks unstable. I think there might be a race condition in what you did.
|
This is a proposal, feel free to dismiss.
The idea is to have:
so that what you need to use is extra clear.
(This PR is part of various things noted when I added the
:topics:
to the guides)BTW, I didn't do it there but I also think we should move the
REST Client Config
extension, which is common to both RESTEasy Classic and RESTEasy Reactive IIUC, outside of the RESTEasy Classic folder. Let me know what you think, I can do it in a follow-up PR.