Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QuarkusComponentTest: initial support for ConfigMapping #36389

Merged
merged 1 commit into from
Oct 11, 2023
Merged

QuarkusComponentTest: initial support for ConfigMapping #36389

merged 1 commit into from
Oct 11, 2023

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Oct 10, 2023

@mkouba mkouba force-pushed the component-test-config-mapping branch 3 times, most recently from 508235c to 42d994b Compare October 11, 2023 05:23
@mkouba mkouba marked this pull request as ready for review October 11, 2023 05:23
@mkouba mkouba requested a review from yrodiere October 11, 2023 05:23
yrodiere
yrodiere approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow that was fast, thanks!

This looks good to me. I didn't know we could set properties per test method, that should come in handy as well.

Just one comment, but it might be irrelevant.

...ework/junit5-component/src/test/java/io/quarkus/test/component/config/ConfigMappingTest.java Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Oct 11, 2023 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@mkouba
Copy link
Contributor Author

mkouba commented Oct 11, 2023

I didn't know we could set properties per test method, that should come in handy as well.

👍 yep, that was a feature request from one of our users.

Keep in mind, that it only works if the test instance lifecycle is Lifecycle#PER_METHOD (default).

@mkouba mkouba force-pushed the component-test-config-mapping branch from 42d994b to 6697d1d Compare October 11, 2023 06:50
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 11, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 11, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@mkouba mkouba merged commit 049f6f0 into quarkusio:main Oct 11, 2023
25 checks passed
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Oct 11, 2023
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Oct 11, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrodiere yrodiere yrodiere approved these changes

Assignees
No one assigned
Labels
area/documentation area/testing kind/enhancement New feature or request
Projects
Quarkus Documentation
Status: Done
Milestone
3.6.0.CR1
Development

Successfully merging this pull request may close these issues.

Support for non-mock @ConfigMapping in @QuarkusComponentTest
2 participants
@mkouba @yrodiere