Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not warn on static init about clearly build-related properties being set in environment variables #36322

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

yrodiere
Copy link
Member

@yrodiere yrodiere commented Oct 6, 2023

Fixes #36291

I think these properties are very clearly about the build, and could reasonably be set globally as environment variables in a development environment.

Arguably we could ignore more, but I tried to be conservative here.

…ng set in environment variables
@yrodiere yrodiere requested a review from radcortez October 6, 2023 08:24
@quarkus-bot quarkus-bot bot added the area/core label Oct 6, 2023
@yrodiere yrodiere added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 6, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 6, 2023

Failing Jobs - Building 0936ebb

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 20 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 20 #

- Failing: integration-tests/virtual-threads/jms-virtual-threads 

📦 integration-tests/virtual-threads/jms-virtual-threads

io.quarkus.it.vthreads.jms.VirtualThreadTest.testAlert - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.artemis.core.deployment.DevServicesArtemisProcessor#startArtemisDevService threw an exception: org.testcontainers.containers.ContainerFetchException: Can't get Docker image: RemoteDockerImage(imageName=quay.io/artemiscloud/activemq-artemis-broker:1.0.18, imagePullPolicy=DefaultPullPolicy(), imageNameSubstitutor=org.testcontainers.utility.ImageNameSubstitutor$LogWrappedImageNameSubstitutor@56403d0e)

@geoand geoand merged commit 0095d5f into quarkusio:main Oct 9, 2023
50 of 51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.5 - main milestone Oct 9, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 9, 2023
@yrodiere yrodiere deleted the build-prop-no-warn branch January 29, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning "Build time property cannot be changed at runtime: quarkus.native.builder-image.pull"
3 participants