Update SmallRye OpenAPI to 3.6.2 #36279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/dependencies
Signed-off-by: Phillip Kruger <[email protected]>
phillip-kruger
force-pushed
the
openapi-update
branch
from
f6b0811 to
86ee5c2
Compare
gsmet
reviewed
Oct 4, 2023
| @@ -90,7 +90,8 @@ public void testOpenAPIJSON() throws Exception { | |||
| Assertions.assertEquals(1, keys.size()); | |||
| Assertions.assertEquals("get", keys.iterator().next()); | |||
|
|
|||
| String uniSchemaType = schemaType("200", DEFAULT_MEDIA_TYPE, uniObj.getJsonObject("get").getJsonObject("responses"), | |||
| String uniSchemaType = schemaType("200", DEFAULT_MEDIA_TYPE_PRIMITAVE, | |||
There was a problem hiding this comment.
Not worth fixing here as it was preexisting but next time you update this test:
Suggested change
| String uniSchemaType = schemaType("200", DEFAULT_MEDIA_TYPE_PRIMITAVE, | |
| String uniSchemaType = schemaType("200", DEFAULT_MEDIA_TYPE_PRIMITIVE, |
gsmet
approved these changes
Oct 4, 2023
cescoffier
approved these changes
Oct 4, 2023
cescoffier
added
the
triage/waiting-for-ci
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update OpenAPI to 3.6.2
Fix #36253
This also implements the default content type for wrapped types as discussed here:
#34700 (comment)