Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Smallrye RM version from 4.9.0 to 4.10.1 #36206

Merged
merged 1 commit into from
Oct 1, 2023
Merged

Bump Smallrye RM version from 4.9.0 to 4.10.1 #36206

merged 1 commit into from
Oct 1, 2023

Conversation

ozangunalp
Copy link
Contributor

@ozangunalp ozangunalp commented Sep 28, 2023 •
edited
Loading

  • Doc update for Kafka guide
  • Auto serde detection for MultiSplitter type
  • ITs updating using multiple outgoings

@github-actions
Copy link

github-actions bot commented Sep 28, 2023 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@quarkus-bot

This comment has been minimized.

Sign in to view
cescoffier
cescoffier requested changes Sep 29, 2023
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid the BOM.
Also, CI failures are related.

bom/application/pom.xml Outdated
@@ -341,6 +341,15 @@
<type>pom</type>
</dependency>

<!-- Smallrye Reactive Messaging dependencies, imported as a BOM -->
<dependency>
<groupId>io.smallrye.reactive</groupId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a great idea. Complexify the productization.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I rolled back, we can hold the discussion later

@ozangunalp
Copy link
Contributor Author

Fixed the related DefaultSerdeConfigTest failures

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 29, 2023

Failing Jobs - Building cadd5a4

Status Name Step Failures Logs Raw logs Build scan
✔️ Gradle Tests - JDK 11
✖ Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.builder.QuarkusModelBuilderTest.shouldLoadMultiModuleTestModel line 66 - More details - Source on GitHub

org.gradle.tooling.BuildException: Could not run build action using connection to Gradle distribution 'https://services.gradle.org/distributions/gradle-8.3-bin.zip'.
	at org.gradle.tooling.internal.consumer.ExceptionTransformer.transform(ExceptionTransformer.java:51)
	at org.gradle.tooling.internal.consumer.ExceptionTransformer.transform(ExceptionTransformer.java:29)

✖ io.quarkus.gradle.builder.QuarkusModelBuilderTest.shouldLoadMultiModuleDevModel line 100 - More details - Source on GitHub

org.gradle.tooling.BuildException: Could not run build action using connection to Gradle distribution 'https://services.gradle.org/distributions/gradle-8.3-bin.zip'.
	at org.gradle.tooling.internal.consumer.ExceptionTransformer.transform(ExceptionTransformer.java:51)
	at org.gradle.tooling.internal.consumer.ExceptionTransformer.transform(ExceptionTransformer.java:29)

@cescoffier cescoffier merged commit 1c87e6f into quarkusio:main Oct 1, 2023
53 of 54 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.5 - main milestone Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file area/documentation area/reactive-messaging area/smallrye
Projects
Quarkus Documentation
Status: Done
Milestone
3.5.0.CR1
Development

Successfully merging this pull request may close these issues.
2 participants
@ozangunalp @cescoffier