Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename tooling codestarts #36194

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Rename tooling codestarts #36194

merged 1 commit into from
Oct 25, 2023

Conversation

ia3andy
Copy link
Contributor

@ia3andy ia3andy commented Sep 28, 2023 •
edited
Loading

The goal is to avoid future conflicts between codestarts

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Sep 28, 2023
@quarkus-bot

This comment has been minimized.

Sign in to view
@ia3andy
Copy link
Contributor Author

ia3andy commented Oct 9, 2023

I was on pto, I will fix the test

@maxandersen
Copy link
Member

aren't these names/ids relied on by past quarkus cli/plugin versions or is this purely local for a given quarkus release? i.e. does renaming these in 3.5 still make a quarkus cli 3.4 or older able to generate apps for 3.5+ ?

@ia3andy
Copy link
Contributor Author

ia3andy commented Oct 9, 2023

aren't these names/ids relied on by past quarkus cli/plugin versions or is this purely local for a given quarkus release? i.e. does renaming these in 3.5 still make a quarkus cli 3.4 or older able to generate apps for 3.5+ ?

They are embedded in a release.

@ia3andy ia3andy force-pushed the rename-tooling-codestarts-2 branch from 3b43252 to 76c2390 Compare October 9, 2023 09:30
@quarkus-bot

This comment has been minimized.

Sign in to view
@maxandersen
Copy link
Member

They are embedded in a release.

okey - so these names are not exposed across versions ?

@quarkus-bot

This comment has been minimized.

Sign in to view
@ia3andy ia3andy force-pushed the rename-tooling-codestarts-2 branch from 76c2390 to 7a851fd Compare October 10, 2023 08:05
@quarkus-bot

This comment has been minimized.

Sign in to view
@ia3andy
Copy link
Contributor Author

ia3andy commented Oct 10, 2023

@gsmet is it me or the CI is a bit flacky these days?

@ia3andy ia3andy requested a review from gsmet October 10, 2023 13:46
@ia3andy ia3andy force-pushed the rename-tooling-codestarts-2 branch from 641cd2c to 067493a Compare October 13, 2023 08:25
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@ia3andy ia3andy force-pushed the rename-tooling-codestarts-2 branch from 067493a to 8a22e58 Compare October 23, 2023 09:34
@quarkus-bot

This comment has been minimized.

Sign in to view
@ia3andy ia3andy force-pushed the rename-tooling-codestarts-2 branch from 8a22e58 to 576617e Compare October 24, 2023 11:59
@quarkus-bot

This comment has been minimized.

Sign in to view
@ia3andy ia3andy force-pushed the rename-tooling-codestarts-2 branch from 576617e to 7862303 Compare October 24, 2023 13:24
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 24, 2023

Failing Jobs - Building 7862303

Status Name Step Failures Logs Raw logs Build scan
✖ JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 17
✖ JVM Tests - JDK 17 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 20
✔️ Maven Tests - JDK 11
✖ Maven Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/micrometer/deployment 
! Skipped: extensions/micrometer-registry-prometheus/deployment extensions/quartz/deployment extensions/scheduler/deployment and 25 more

📦 extensions/micrometer/deployment

✖ io.quarkus.micrometer.deployment.binder.StorkMetricsDisabledTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.redis.deployment.client.DevServicesRedisProcessor#startRedisContainers threw an exception: java.lang.RuntimeException: java.lang.IllegalStateException: Previous attempts to find a Docker environment failed. Will not retry. Please see logs and check configuration

⚙️ Maven Tests - JDK 11 Windows #

📦 integration-tests/maven

✖ io.quarkus.maven.it.DevMojoIT.testExternalReloadableArtifacts line 1448 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.DevMojoIT was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.DevMojoIT.testExternalReloadableArtifacts line 1448 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.DevMojoIT was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.JarRunnerIT.testNonAsciiDir line 70 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.maven.it.JarRunnerIT.testNonAsciiDir line 70 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.maven.it.JarRunnerIT.testPlatformPropertiesOverridenInApplicationProperties line 135 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.JarRunnerIT that uses io.quarkus.maven.it.verifier.MavenProcessInvocationResult was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.JarRunnerIT.testPlatformPropertiesOverridenInApplicationProperties line 135 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.JarRunnerIT that uses io.quarkus.maven.it.verifier.MavenProcessInvocationResult was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.UberJarQuarkusIntegrationTestIT.testUberJar line 13 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.QuarkusITBase that uses io.quarkus.maven.it.verifier.MavenProcessInvocationResult was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.UberJarQuarkusIntegrationTestIT.testUberJar line 13 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.QuarkusITBase that uses io.quarkus.maven.it.verifier.MavenProcessInvocationResult was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@gsmet gsmet merged commit 8d8610a into quarkusio:main Oct 25, 2023
48 of 51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@maxandersen maxandersen Awaiting requested review from maxandersen

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Milestone
3.6.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@ia3andy @maxandersen @gsmet