Fix version after which org.graalvm.nativeimage needs to be exported #36063
+17
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zakkak
force-pushed
the
2023-09-21-fix-nativeimage-export-v2
branch
from
d516965 to
2fdf6d5
Compare
gsmet
reviewed
Sep 21, 2023
| @@ -53,7 +53,7 @@ void addExportsToNativeImage(BuildProducer<JPMSExportBuildItem> features) { | |||
| features.produce(new JPMSExportBuildItem("org.graalvm.sdk", "org.graalvm.nativeimage.impl", null, | |||
| GraalVM.Version.VERSION_23_1_0)); | |||
| features.produce(new JPMSExportBuildItem("org.graalvm.nativeimage", "org.graalvm.nativeimage.impl", | |||
| GraalVM.Version.VERSION_23_0_0)); | |||
| GraalVM.Version.VERSION_23_1_0)); | |||
There was a problem hiding this comment.
I'm surprised it's the only one that needs changing? I would have expected all the current entries to be adjusted?
There was a problem hiding this comment.
This is the only place the constructor setting the exportSince is used. Thankfully we don't have to export many things :)
|
CI failed due to timeout. |
gsmet
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to export the module after 23.0.x not after 23.0.0, i.e., when using 23.0.1 we should not export it.
Wrong version introduced in #35377
Supersedes: #36058
Closes: #36053