Make Maven ITs less fragile #35996

gsmet · 2023-09-18T14:15:33Z

Enforcing versions of the plugins make sure we don't start downloading
them when running the tests which can lead to timeouts.
Also it makes the build more stable and actually tests the version we
are using when creating new projects.

Created as draft as I'd like Alexey's feedback.

To reproduce:

get this PR
drop this commit as it fixes the issue: d7922d9
mvn clean install
mvn clean install -f integration-tests/maven -Dtest=DevMojoIT#testThatSourceChangesAreDetectedOnPomChange

My understanding is that if compile is in the command line, we don't execute it ourselves but... when we are restarting dev mode due to a POM change, we should run compile again.

Sanne · 2023-10-13T08:52:40Z

@aloubyansky Looks like your feedback was requested, but not explicitly.. HTH

gsmet · 2023-10-13T09:07:45Z

Unfortunately, the last commit is problematic as I used valid ascii characters. I'm not completely sure what's going on with this test as I saw it failing in some of our regular builds, even without this change.

I'll revert the ascii one and see how CI goes.

aloubyansky · 2023-10-16T06:50:27Z

integration-tests/maven/src/test/java/io/quarkus/maven/it/DevMojoIT.java

@@ -474,7 +474,10 @@ public void testThatSourceChangesAreDetectedOnPomChange() throws Exception {
        await()
                .pollDelay(100, TimeUnit.MILLISECONDS)
                .atMost(1, TimeUnit.MINUTES)
-                .until(() -> devModeClient.getHttpResponse("/app/hello").contains("hello " + uuid));
+                .until(() -> {
+                    System.out.println(devModeClient.getHttpResponse("/app/hello"));


Did you mean to keep it a part of the commit?

Enforcing versions of the plugins make sure we don't start downloading them when running the tests which can lead to timeouts. Also it makes the build more stable and actually tests the version we are using when creating new projects.

When running mvn compile quarkus:dev, compile is not executed when restarting dev mode after the pom change. Not specifying compile makes the compile goal to be run.

With maven-compiler-plugin 2.11.0, this test is not working anymore on Windows: Error while storing the mojo status: Input length = 1

We need to see the details of the errors when something is going wrong.

Installing the lib jar a second time leads to an access denied exception on Windows, probably because the jar is still used by the dev mode instance.

quarkus-bot · 2023-10-25T19:53:53Z

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven labels Sep 18, 2023

gsmet force-pushed the better-maven-its branch from d7922d9 to 5465b32 Compare September 22, 2023 14:20

gsmet marked this pull request as ready for review September 22, 2023 14:29