-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify wiremock config in oidc #35749
Conversation
Thanks, though now that I think about it, may be it is better to have 2 commits in this PR, one bump the version, another update the OIDC test code. Guillaume, do you have any preferences ? |
This comment has been minimized.
This comment has been minimized.
Yeah, that's probably best |
ebc02d7
to
9533032
Compare
Done |
9533032
to
26e0e8e
Compare
Failing Jobs - Building 26e0e8e
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 20 #- Failing: devtools/cli
📦 devtools/cli✖
✖
✖
⚙️ Maven Tests - JDK 11 Windows #- Failing: integration-tests/maven
📦 integration-tests/maven✖
✖
|
The test failures are not related |
In wiremock 3,
ResponseTemplateTransformer
should not be created manually; see wiremock/wiremock#2350 (comment)Wiremock now creates one internally, by default local. Also made few simplifications within the same class by using static imports + bump to 3.0.3 while at it.
follows up on #35649
supersedes #35820
supersedes #35821