Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid storing the whole BuildResult in StartupActionImpl #35394

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Aug 17, 2023

The BuildResult contains references to all the build items, some of them contain references to class loaders or objects of significant size.

Note that it has value because StartupActionImpl is leaked as a reference of various non-static nested classes. I experimented with dropping the nested classes but it makes things harder to follow and I think this patch will improve things a lot already.

The BuildResult contains references to all the build items, some of them
contain references to class loaders or objects of significant size.
@yrodiere
Copy link
Member

I included this in #35407, so if that one gets merged we'll want to close this one.

@yrodiere yrodiere closed this Aug 17, 2023
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Aug 17, 2023
@yrodiere yrodiere reopened this Aug 17, 2023
@quarkus-bot quarkus-bot bot removed the triage/invalid This doesn't seem right label Aug 17, 2023
@yrodiere yrodiere added triage/invalid This doesn't seem right and removed triage/invalid This doesn't seem right labels Aug 17, 2023
@gsmet gsmet marked this pull request as ready for review August 17, 2023 16:52
@gsmet gsmet requested a review from stuartwdouglas August 17, 2023 16:59
@gsmet
Copy link
Member Author

gsmet commented Aug 17, 2023

Let's keep them separate as I like keeping track of my work in PRs.

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 18, 2023

Failing Jobs - Building fce2443

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs
JVM Tests - JDK 20 Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/grpc/deployment 
! Skipped: extensions/micrometer-registry-prometheus/deployment extensions/micrometer/deployment extensions/opentelemetry/deployment and 52 more

📦 extensions/grpc/deployment

io.quarkus.grpc.server.MutinyGrpcServiceWithSSLTest.testEmptyWithMutinyClient - More details - Source on GitHub

io.smallrye.mutiny.TimeoutException
	at io.smallrye.mutiny.operators.uni.UniBlockingAwait.await(UniBlockingAwait.java:64)
	at io.smallrye.mutiny.groups.UniAwait.atMost(UniAwait.java:65)

@gsmet gsmet merged commit a405951 into quarkusio:main Aug 18, 2023
@quarkus-bot quarkus-bot bot added this to the 3.4 - main milestone Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants