Avoid storing the whole BuildResult in StartupActionImpl #35394
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BuildResult contains references to all the build items, some of them contain references to class loaders or objects of significant size.
Note that it has value because
StartupActionImpl
is leaked as a reference of various non-static nested classes. I experimented with dropping the nested classes but it makes things harder to follow and I think this patch will improve things a lot already.