Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuarkusComponentTest: another fix for continuous testing integration #35259

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Aug 8, 2023

  • it seems that classloading in the continuous testing environment has changed recently; this commit should fix the problem
  • also add a test so that we can catch similar problems in the CI

@mkouba mkouba changed the title QuarkusComponentTest: another fix for continous testing integration QuarkusComponentTest: another fix for continuous testing integration Aug 8, 2023
- it seems that classloading in the continuous testing environment has
changed recently; this commit should fix the problem
- also add a test so that we can catch similar problems in the CI
@mkouba mkouba force-pushed the component-continous-test-fix-02 branch from 9012d4b to 9b7a8fe Compare August 8, 2023 12:39
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 8, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link
Contributor

@holly-cummins holly-cummins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The big test classloading changes are still to come (at least, the ones I know about :) ) ... but this change looks good, and having the extra coverage will be useful.

@mkouba mkouba merged commit 2db3a79 into quarkusio:main Aug 8, 2023
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants