Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that tests using QuarkusDevModeTest run in black box mode #35212

Merged
merged 1 commit into from
Aug 5, 2023
Merged

Clarify that tests using QuarkusDevModeTest run in black box mode #35212

merged 1 commit into from
Aug 5, 2023

Conversation

yrodiere
Copy link
Member

@yrodiere yrodiere commented Aug 4, 2023

@yrodiere yrodiere requested a review from geoand August 4, 2023 16:22
@yrodiere
Copy link
Member Author

yrodiere commented Aug 4, 2023

cc @mmusgrov

geoand
geoand approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@yrodiere yrodiere added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 4, 2023
@gsmet gsmet merged commit 972fcce into quarkusio:main Aug 5, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 5, 2023
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Aug 5, 2023
mmusgrov
mmusgrov reviewed Aug 7, 2023
View reviewed changes
Copy link
Contributor

@mmusgrov mmusgrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change adds clarity, thanks.

@yrodiere yrodiere deleted the quarkusdevmodetest-docs branch August 7, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmusgrov mmusgrov mmusgrov left review comments

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/testing
Projects
None yet
Milestone
3.3.0.CR1
Development

Successfully merging this pull request may close these issues.
4 participants
@yrodiere @mmusgrov @geoand @gsmet