-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Old Dev UI: Core Configuration #35163
Merged
phillip-kruger
merged 1 commit into
quarkusio:main
from
phillip-kruger:dev-ui-remove-configuration
Aug 4, 2023
Merged
Remove Old Dev UI: Core Configuration #35163
phillip-kruger
merged 1 commit into
quarkusio:main
from
phillip-kruger:dev-ui-remove-configuration
Aug 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 tasks
gsmet
force-pushed
the
dev-ui-remove-configuration
branch
from
August 2, 2023 14:34
8fd141e
to
dc5e526
Compare
This comment has been minimized.
This comment has been minimized.
phillip-kruger
force-pushed
the
dev-ui-remove-configuration
branch
2 times, most recently
from
August 3, 2023 00:39
4f913ae
to
61518e6
Compare
This comment has been minimized.
This comment has been minimized.
Ok hold on let me fix the conflict |
geoand
approved these changes
Aug 3, 2023
phillip-kruger
force-pushed
the
dev-ui-remove-configuration
branch
from
August 3, 2023 11:04
61518e6
to
367fb14
Compare
phillip-kruger
added
the
triage/waiting-for-ci
Ready to merge when CI successfully finishes
label
Aug 3, 2023
CI might fail due to the other issue, so I'll rebase again once libs PR is in |
This comment has been minimized.
This comment has been minimized.
phillip-kruger
force-pushed
the
dev-ui-remove-configuration
branch
from
August 3, 2023 15:15
367fb14
to
d56a90b
Compare
Signed-off-by: Phillip Kruger <[email protected]>
phillip-kruger
force-pushed
the
dev-ui-remove-configuration
branch
from
August 4, 2023 01:51
d56a90b
to
edf26f3
Compare
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Ready to merge when CI successfully finishes
label
Aug 4, 2023
this commit removed the config console command - was that intentional @phillip-kruger ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This remove the old dev ui and convert the relevant tests