Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Old Dev UI: Core Configuration #35163

Merged

Conversation

phillip-kruger
Copy link
Member

This remove the old dev ui and convert the relevant tests

@phillip-kruger phillip-kruger requested a review from gsmet August 2, 2023 10:38
@phillip-kruger phillip-kruger mentioned this pull request Aug 2, 2023
42 tasks
@gsmet gsmet force-pushed the dev-ui-remove-configuration branch from 8fd141e to dc5e526 Compare August 2, 2023 14:34
@quarkus-bot

This comment has been minimized.

@phillip-kruger phillip-kruger force-pushed the dev-ui-remove-configuration branch 2 times, most recently from 4f913ae to 61518e6 Compare August 3, 2023 00:39
@quarkus-bot

This comment has been minimized.

@phillip-kruger phillip-kruger requested a review from geoand August 3, 2023 10:45
@phillip-kruger
Copy link
Member Author

Ok hold on let me fix the conflict

@phillip-kruger phillip-kruger force-pushed the dev-ui-remove-configuration branch from 61518e6 to 367fb14 Compare August 3, 2023 11:04
@phillip-kruger phillip-kruger added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 3, 2023
@phillip-kruger
Copy link
Member Author

phillip-kruger commented Aug 3, 2023

CI might fail due to the other issue, so I'll rebase again once libs PR is in

@quarkus-bot

This comment has been minimized.

@phillip-kruger phillip-kruger force-pushed the dev-ui-remove-configuration branch from 367fb14 to d56a90b Compare August 3, 2023 15:15
@phillip-kruger phillip-kruger force-pushed the dev-ui-remove-configuration branch from d56a90b to edf26f3 Compare August 4, 2023 01:51
@quarkusio quarkusio deleted a comment from quarkus-bot bot Aug 4, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 4, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@phillip-kruger phillip-kruger merged commit f6f0849 into quarkusio:main Aug 4, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 4, 2023
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Aug 4, 2023
@phillip-kruger phillip-kruger deleted the dev-ui-remove-configuration branch August 4, 2023 08:54
@maxandersen
Copy link
Member

this commit removed the config console command - was that intentional @phillip-kruger ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants