Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip flaky jms virtual threads until fix #35085

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

ozangunalp
Copy link
Contributor

jms-virtual-threads IT introduced in #35018 is flaky.

This PR skips the tests for that module.

Probably due to a bug in RM JMS connector :

2023-07-28 15:07:04,415 ERROR [io.sma.rea.mes.provider] (quarkus-virtual-thread-55) SRMSG00201: Error caught while processing a message in method io.quarkus.it.vthreads.jms.PriceConsumer#consume: java.util.concurrent.RejectedExecutionException: Task java.util.concurrent.CompletableFuture$AsyncRun@17571b45 rejected from java.util.concurrent.ThreadPoolExecutor@74109346[Running, pool size = 10, active threads = 9, queued tasks = 0, completed tasks = 69]
	at [email protected]/java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2081)
	at [email protected]/java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:841)
	at [email protected]/java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1376)
	at [email protected]/java.util.concurrent.CompletableFuture.asyncRunStage(CompletableFuture.java:1818)
	at [email protected]/java.util.concurrent.CompletableFuture.runAsync(CompletableFuture.java:2033)
	at io.smallrye.reactive.messaging.jms.IncomingJmsMessage.ack(IncomingJmsMessage.java:113)
	at io.smallrye.reactive.messaging.providers.SubscriberMediator.lambda$handleInvocationResult$11(SubscriberMediator.java:197)
	at io.smallrye.context.impl.wrappers.SlowContextualBiFunction.apply(SlowContextualBiFunction.java:21)
	at io.smallrye.mutiny.operators.uni.UniOnItemOrFailureFlatMap$UniOnItemOrFailureFlatMapProcessor.performInnerSubscription(UniOnItemOrFailureFlatMap.java:86)
	at io.smallrye.mutiny.operators.uni.UniOnItemOrFailureFlatMap$UniOnItemOrFailureFlatMapProcessor.onItem(UniOnItemOrFailureFlatMap.java:54)
	at io.smallrye.mutiny.operators.uni.UniOnItemOrFailureFlatMap$UniOnItemOrFailureFlatMapProcessor.onItem(UniOnItemOrFailureFlatMap.java:56)
	at io.smallrye.mutiny.operators.uni.builders.DefaultUniEmitter.complete(DefaultUniEmitter.java:37)
	at io.quarkus.smallrye.reactivemessaging.runtime.QuarkusWorkerPoolRegistry.lambda$runOnVirtualThread$7(QuarkusWorkerPoolRegistry.java:105)
	at io.smallrye.context.impl.wrappers.SlowContextualConsumer.accept(SlowContextualConsumer.java:21)
	at io.smallrye.mutiny.operators.uni.builders.UniCreateWithEmitter.subscribe(UniCreateWithEmitter.java:22)
	at io.smallrye.mutiny.operators.AbstractUni.subscribe(AbstractUni.java:36)
	at io.smallrye.mutiny.operators.uni.UniOnItemOrFailureFlatMap$UniOnItemOrFailureFlatMapProcessor.performInnerSubscription(UniOnItemOrFailureFlatMap.java:99)
	at io.smallrye.mutiny.operators.uni.UniOnItemOrFailureFlatMap$UniOnItemOrFailureFlatMapProcessor.onItem(UniOnItemOrFailureFlatMap.java:54)
	at io.smallrye.mutiny.operators.uni.UniOperatorProcessor.onItem(UniOperatorProcessor.java:47)
	at io.smallrye.mutiny.operators.uni.builders.DefaultUniEmitter.complete(DefaultUniEmitter.java:37)
	at io.smallrye.reactive.messaging.providers.AbstractMediator.lambda$invokeBlocking$11(AbstractMediator.java:175)
	at io.smallrye.context.impl.wrappers.SlowContextualConsumer.accept(SlowContextualConsumer.java:21)
	at io.smallrye.mutiny.operators.uni.builders.UniCreateWithEmitter.subscribe(UniCreateWithEmitter.java:22)
	at io.smallrye.mutiny.operators.AbstractUni.subscribe(AbstractUni.java:36)
	at io.smallrye.mutiny.operators.uni.UniRunSubscribeOn.lambda$subscribe$0(UniRunSubscribeOn.java:27)
	at [email protected]/java.util.concurrent.ThreadPerTaskExecutor$TaskRunner.run(ThreadPerTaskExecutor.java:314)
	at [email protected]/java.lang.VirtualThread.runWith(VirtualThread.java:335)
	at [email protected]/java.lang.VirtualThread.run(VirtualThread.java:305)
	at [email protected]/java.lang.VirtualThread$VThreadContinuation.lambda$new$0(VirtualThread.java:177)
	at [email protected]/jdk.internal.vm.Continuation.enter(Continuation.java:169)

@ozangunalp ozangunalp requested a review from geoand July 28, 2023 13:20
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 28, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 28, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@geoand geoand merged commit c6b253c into quarkusio:main Jul 28, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 28, 2023
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Jul 28, 2023
@ozangunalp ozangunalp deleted the vthreads_jms_test_skip branch July 28, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants