-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for programmatic mapping and mapping configurers #35026
Merged
yrodiere
merged 1 commit into
quarkusio:main
from
marko-bekhta:feat/i32760-search-programmatic-mapping
Aug 4, 2023
Merged
Add support for programmatic mapping and mapping configurers #35026
yrodiere
merged 1 commit into
quarkusio:main
from
marko-bekhta:feat/i32760-search-programmatic-mapping
Aug 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
yrodiere
reviewed
Aug 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. A few comments below.
...ch/orm/elasticsearch/runtime/HibernateSearchElasticsearchBuildTimeConfigPersistenceUnit.java
Outdated
Show resolved
Hide resolved
marko-bekhta
force-pushed
the
feat/i32760-search-programmatic-mapping
branch
from
August 3, 2023 16:56
5653b71
to
ce95c11
Compare
Failing Jobs - Building ce95c11
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
|
yrodiere
approved these changes
Aug 4, 2023
yrodiere
changed the title
Add a configuration property for mapping configurers
Add support for programmatic mapping and mapping configurers
Aug 4, 2023
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/documentation
area/hibernate-search
Hibernate Search
kind/enhancement
New feature or request
triage/flaky-test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32760
While working on this, I noticed that imports in the analysis example were not matching the code and that one entity was missing from the analysis tests, so I adjusted that.
Also, I assumed that in this case, we would want to collect all the configurers, be it from the properties or the ones annotated with a
@SearchExtension
, compared to how the analysis does it (property can replace the extension configurer)