Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for programmatic mapping and mapping configurers #35026

Conversation

marko-bekhta
Copy link
Contributor

@marko-bekhta marko-bekhta commented Jul 26, 2023

Fixes #32760

While working on this, I noticed that imports in the analysis example were not matching the code and that one entity was missing from the analysis tests, so I adjusted that.

Also, I assumed that in this case, we would want to collect all the configurers, be it from the properties or the ones annotated with a @SearchExtension, compared to how the analysis does it (property can replace the extension configurer)

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 26, 2023

/cc @gsmet (hibernate-search), @yrodiere (hibernate-search)

@github-actions
Copy link

github-actions bot commented Jul 26, 2023

🙈 The PR is closed and the preview is expired.

@quarkus-bot

This comment has been minimized.

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. A few comments below.

@marko-bekhta marko-bekhta force-pushed the feat/i32760-search-programmatic-mapping branch from 5653b71 to ce95c11 Compare August 3, 2023 16:56
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 3, 2023

Failing Jobs - Building ce95c11

Status Name Step Failures Logs Raw logs
✔️ Gradle Tests - JDK 11
Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.devmode.KotlinProjectWithCompilerArgsDevModeTest.main line 17 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@yrodiere yrodiere changed the title Add a configuration property for mapping configurers Add support for programmatic mapping and mapping configurers Aug 4, 2023
@yrodiere
Copy link
Member

yrodiere commented Aug 4, 2023

LGTM, thanks!

@yrodiere yrodiere merged commit 15ee135 into quarkusio:main Aug 4, 2023
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Aug 4, 2023
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quarkus Hibernate search programmatic API
2 participants