Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev UI: Remove link to prev dev ui #34970

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

phillip-kruger
Copy link
Member

After this we will start remove the prev dev ui

@quarkus-bot

This comment has been minimized.

@geoand
Copy link
Contributor

geoand commented Jul 25, 2023

VertxBlockingMutinyTest seems to be pretty unstable

@gsmet
Copy link
Member

gsmet commented Jul 25, 2023

@cescoffier @DavideD @alesj not sure who is taking care of com.example.grpc.hibernate.VertxBlockingMutinyTest.shouldAddItems but it has been failing for several days pretty often.

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 25, 2023

Failing Jobs - Building 366875c

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs
JVM Tests - JDK 19 Build Failures Logs Raw logs
✔️ Maven Tests - JDK 11
Maven Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/grpc/deployment 
! Skipped: extensions/micrometer-registry-prometheus/deployment extensions/micrometer/deployment extensions/opentelemetry/deployment and 48 more

📦 extensions/grpc/deployment

io.quarkus.grpc.server.blocking.BlockingOnClassTest.shouldOffloadBlockingOnSuperclassImplementation - More details - Source on GitHub

io.grpc.StatusRuntimeException: INTERNAL: Half-closed without a request
	at io.grpc.Status.asRuntimeException(Status.java:539)
	at io.grpc.stub.ClientCalls$StreamObserverToCallListenerAdapter.onClose(ClientCalls.java:491)

📦 integration-tests/grpc-hibernate

com.example.grpc.hibernate.VertxBlockingMutinyTest.shouldAddItems - More details - Source on GitHub

io.smallrye.mutiny.TimeoutException
	at io.smallrye.mutiny.operators.uni.UniBlockingAwait.await(UniBlockingAwait.java:64)
	at io.smallrye.mutiny.groups.UniAwait.atMost(UniAwait.java:65)

⚙️ JVM Tests - JDK 19 #

- Failing: integration-tests/grpc-hibernate 

📦 integration-tests/grpc-hibernate

com.example.grpc.hibernate.VertxBlockingMutinyTest.shouldAddViaBidi - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with com.example.grpc.hibernate.BlockingMutinyTestBase was not fulfilled within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

com.example.grpc.hibernate.VertxBlockingMutinyTest.shouldAddItems - More details - Source on GitHub

io.smallrye.mutiny.CompositeException: 
Multiple exceptions caught:
	[Exception 0] io.grpc.StatusRuntimeException: INTERNAL: Half-closed without a request

@phillip-kruger
Copy link
Member Author

This PR is a very small UI only change. @gsmet is it ok to merge with the current CI failures ? Else I can rebase and see if CI pass ?

@gsmet gsmet merged commit e787479 into quarkusio:main Jul 25, 2023
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Jul 25, 2023
@gsmet
Copy link
Member

gsmet commented Jul 25, 2023

I think I will disable these failing gRPC tests are they are getting very annoying.

@phillip-kruger
Copy link
Member Author

Thanks @gsmet !

@phillip-kruger phillip-kruger deleted the dev-ui-remove-link-to-old branch July 25, 2023 13:26
@cescoffier
Copy link
Member

@gsmet yes... it became flaky a few days ago. We need to have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants