Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Virtual Thread ITs #34954

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Virtual Thread ITs #34954

merged 1 commit into from
Jul 25, 2023

Conversation

cescoffier
Copy link
Member

Verify the behavior of virtual threads

  • RESTEasy Reactive (check dispatching strategy, filters, no pinning...)
  • Reactive rest client (no pinning)
  • gRPC client (no pinning)
  • Mailer (both simple and template) (no pinning)
  • Redis (client and cache) (no pinning)
  • Enable native tests

@cescoffier cescoffier requested review from ozangunalp and geoand July 24, 2023 13:23
@quarkus-bot quarkus-bot bot added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label Jul 24, 2023
@cescoffier cescoffier force-pushed the virtual-thread-tests branch from 93c5220 to 9aa2122 Compare July 24, 2023 13:34
geoand
geoand reviewed Jul 24, 2023
View reviewed changes
.github/workflows/ci-actions-incremental.yml
@@ -636,7 +636,7 @@ jobs:
java-version: ${{ matrix.java.java-version }}
- name: Run tests
run: |
export LANG=en_US && ./mvnw -e -B -fae --settings .github/mvn-settings.xml -f integration-tests/virtual-threads clean verify -Dextra-args=${{matrix.java.extra-args}}
export LANG=en_US && ./mvnw -e -B -fae --settings .github/mvn-settings.xml -f integration-tests/virtual-threads clean verify -Dnative -Dextra-args=${{matrix.java.extra-args}} -Dquarkus.native.container-build=true -Dquarkus.native.builder-image=quay.io/quarkus/ubi-quarkus-mandrel-builder-image:jdk-20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to remember to update this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is a temporary solution until 21 is there.

When we add 21 support, we will pick the image automatically.

@quarkus-bot

This comment has been minimized.

Sign in to view
@cescoffier
Verify the behavior of virtual threads
9aedcc5 
- RESTEasy Reactive (check dispatching strategy, filters, no pinning...)
- Reactive rest client (no pinning)
- gRPC client (no pinning)
- Mailer (both simple and template) (no pinning)
- Redis (client and cache) (no pinning)
@cescoffier cescoffier force-pushed the virtual-thread-tests branch from 9aa2122 to 9aedcc5 Compare July 25, 2023 07:35
ozangunalp
ozangunalp approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@ozangunalp ozangunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I have an upcoming branch on this adding the reactive messaging tests with virtual threads.

I was thinking, maybe we can bump Java 19 branch to Java 20 to include these tests in JVM.

That way, instead of filtering integration-tests/virtual-threads module out of the regular build we could only skip test execution <20.
And for native tests, we could add a job, +/- in the same way as the current native tests to filter only impacted tests.

@ozangunalp ozangunalp added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 25, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 25, 2023

Failing Jobs - Building 9aedcc5

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
⌛ JVM Tests - JDK 17 Build ⚠️ Check → Logs Raw logs
✖ JVM Tests - JDK 19 Build Failures Logs Raw logs
✔️ Maven Tests - JDK 11
⌛ Maven Tests - JDK 11 Windows Build Failures Logs Raw logs
⌛ Native Tests - Security1 Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 19 #

- Failing: integration-tests/grpc-hibernate

📦 integration-tests/grpc-hibernate

✖ com.example.grpc.hibernate.VertxBlockingMutinyTest.shouldAddItems - More details - Source on GitHub

io.smallrye.mutiny.CompositeException: 
Multiple exceptions caught:
	[Exception 0] io.grpc.StatusRuntimeException: INTERNAL: Half-closed without a request

⚙️ Maven Tests - JDK 11 Windows #

📦 integration-tests/maven

✖ io.quarkus.maven.it.DevMojoIT.testResourcesFromClasspath line 1234 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.maven.it.DevMojoIT was not fulfilled within 20 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.DevMojoIT.testConfigFactoryInAppModuleFilteredInCodeGen line 88 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.DevMojoIT.testResourcesFromClasspath line 1234 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.maven.it.DevMojoIT was not fulfilled within 20 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.DevMojoIT.testConfigFactoryInAppModuleFilteredInCodeGen line 88 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@cescoffier cescoffier merged commit 599879b into quarkusio:main Jul 25, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 25, 2023
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Jul 25, 2023
@cescoffier cescoffier deleted the virtual-thread-tests branch July 25, 2023 17:51
@ozangunalp ozangunalp mentioned this pull request Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@ozangunalp ozangunalp ozangunalp approved these changes

Assignees
No one assigned
Labels
area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure
Projects
None yet
Milestone
3.3.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@cescoffier @ozangunalp @geoand