Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev UI: Migrate Kafka Client UI #34871

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Dev UI: Migrate Kafka Client UI #34871

merged 1 commit into from
Jul 20, 2023

Conversation

phillip-kruger
Copy link
Member

@phillip-kruger phillip-kruger commented Jul 20, 2023 •
edited
Loading

Fix #32594

This PR migrate the Kafka Dev UI over to the new Dev UI.

  • In the old Dev UI the Schema registry page was not implemented, so it's also not implemented here.
  • Since this is a complex flow in terms of screens, there is some things that we can added to the Dev UI Framework to make that easier. For now I just left TODOs in the code, until the framework is enhanced to allow these.
  • I did not test the access control screen
  • There might be some validation missing on the creating of topics and messages. Let's merge this and then the owners of the extensions can enhance further.

kafka-topics
kafka-consumer-groups
kafka-other

@phillip-kruger phillip-kruger force-pushed the dev-ui-kafka branch 4 times, most recently from 9b1f672 to 8cca5f9 Compare July 20, 2023 04:30
@phillip-kruger phillip-kruger added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 20, 2023
ozangunalp
ozangunalp requested changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@ozangunalp ozangunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just the issue with dialog panes keeping old values

extensions/kafka-client/deployment/src/main/resources/dev-ui/qwc-kafka-add-message.js Show resolved Hide resolved
extensions/kafka-client/deployment/src/main/resources/dev-ui/qwc-kafka-add-message.js Show resolved Hide resolved
@quarkus-bot

This comment has been minimized.

Sign in to view
@phillip-kruger
Dev UI: Migrate Kafka Client UI
ff6eb79 
Signed-off-by: Phillip Kruger <[email protected]>
@phillip-kruger
Copy link
Member Author

@ozangunalp fixed and rebased . please check

@ozangunalp
Copy link
Contributor

Looks good!

@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 20, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@phillip-kruger phillip-kruger merged commit e60b52a into quarkusio:main Jul 20, 2023
@quarkus-bot quarkus-bot bot added kind/enhancement New feature or request and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jul 20, 2023
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Jul 20, 2023
@phillip-kruger phillip-kruger deleted the dev-ui-kafka branch August 11, 2023 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

@ozangunalp ozangunalp ozangunalp approved these changes

Assignees
No one assigned
Labels
area/kafka area/vertx kind/enhancement New feature or request
Projects
None yet
Milestone
3.3.0.CR1
Development

Successfully merging this pull request may close these issues.

Dev UI: Migrate Kafka client to the new Dev UI
3 participants
@phillip-kruger @ozangunalp @cescoffier