Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove com.typesafe.netty:netty-reactive-streams exclusion from org.asynchttpclient:async-http-client #34840

Conversation

jamesnetherton
Copy link
Contributor

From what I can tell, netty-reactive-streams is not optional for the async-http-client:

https://github.com/AsyncHttpClient/async-http-client/blob/async-http-client-project-2.12.3/client/pom.xml#L67-L70

In a few extensions that use it in Camel Quarkus I see:

2023-07-19 07:18:50,060 DEBUG [org.asy.net.han.HttpHandler] (AsyncHttpClient-3-1) Unexpected I/O exception on channel [id: 0x9ed333da, L:/127.0.0.1:49290 - R:localhost/127.0.0.1:37861]: java.lang.ClassNotFoundException: com.typesafe.netty.HandlerPublisher
        at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
        at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
        at io.quarkus.bootstrap.classloading.QuarkusClassLoader.loadClass(QuarkusClassLoader.java:516)
        at io.quarkus.bootstrap.classloading.QuarkusClassLoader.loadClass(QuarkusClassLoader.java:466)
        at java.base/java.lang.ClassLoader.defineClass1(Native Method)
        at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1012)
        at io.quarkus.bootstrap.classloading.QuarkusClassLoader.loadClass(QuarkusClassLoader.java:506)
        at io.quarkus.bootstrap.classloading.QuarkusClassLoader.loadClass(QuarkusClassLoader.java:466)
        at org.asynchttpclient.netty.handler.AsyncHttpClientHandler.isHandledByReactiveStreams(AsyncHttpClientHandler.java:228)
        at org.asynchttpclient.netty.handler.AsyncHttpClientHandler.channelReadComplete(AsyncHttpClientHandler.java:220)
        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelReadComplete(AbstractChannelHandlerContext.java:486)

@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Jul 19, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 19, 2023

Failing Jobs - Building e47afde

Status Name Step Failures Logs Raw logs
✔️ Maven Tests - JDK 11
Maven Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs

@gsmet gsmet requested a review from cescoffier July 19, 2023 15:29
@cescoffier
Copy link
Member

Actually, it may break the native compilation of pulsar application. Better wait for @ozangunalp.

Copy link
Contributor

@ozangunalp ozangunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be ok. The exclusion still applies in the pulsar extension. It was there to resolve a dependency convergence issue – the pulsar client depends on a different version.

@jamesnetherton
Copy link
Contributor Author

@cescoffier can we merge?

@cescoffier cescoffier merged commit 7300b25 into quarkusio:main Jul 20, 2023
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Jul 20, 2023
@jamesnetherton jamesnetherton deleted the remove-exclusion-netty-reactive-streams branch July 20, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants