Do not make OIDC state cookie name unique if multiple code flows are not allowed #34784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OOM dev test test failure, I'll need to create another issue as it is not related to this PR |
|
I've tried to cancel the workflow as one of the OIDC tests is indeed failing, sorry |
|
The OIDC wiremock test failure is not related, it is a millisec related comparison: I'll need to fix it first |
gastaldi
approved these changes
Jul 17, 2023
sberyozkin
force-pushed
the
oidc_state_cookie_without_uuid
branch
from
eb26230 to
8007ddf
Compare
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34760
Quarkus OIDC enables multiple authorization code flows (multi-tab authentication) by default - a user can start a login process and without completing it open a new tab and start a new one.
State cookies are used to coordinate a given authorization code flow and for multiple code flows to be supported their names have to be unique for the state cookies not to interfere with each other.
However if such a multi-tab authentication is disabled, the state cookie should not be unique - as it prevents whitelisting supported cookies as explained in #34760.
So this PR makes a very simple fix - if multiple code flows are not allowed, do not try to make a state cookie name unique. Tests are updated to show that by default the state cookie name contains UUID, but not if the multiple code flows are not allowed.