Undertow correct path when building on Windows to Docker #34611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melloware
force-pushed
the
revert-undertow
branch
from
e14a800 to
68af807
Compare
|
cc @stuartwdouglas @gastaldi if someone wouldn't mind kicking off the build? |
gastaldi
reviewed
Jul 7, 2023
...ons/undertow/runtime/src/main/java/io/quarkus/undertow/runtime/KnownPathResourceManager.java
Outdated
Show resolved
Hide resolved
|
Mind squashing the commits before triggering the CI again? |
melloware
force-pushed
the
revert-undertow
branch
from
f5a2f8f to
6e49bd7
Compare
|
Squashed! |
gastaldi
approved these changes
Jul 7, 2023
Failing Jobs - Building 6e49bd7
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the ongoing saga of #28028 it was reported to me on Quarkus Faces the issue here:
melloware/quarkus-faces#282
I was able to verify the issue and fix it so it now works on either Linux or Windows