Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the javadoc of RecorderContext#classProxy() #34607

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Improve the javadoc of RecorderContext#classProxy() #34607

merged 1 commit into from
Jul 11, 2023

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jul 7, 2023 •
edited
Loading

  • Update the docs

@quarkus-bot quarkus-bot bot added the area/core label Jul 7, 2023
@mkouba mkouba marked this pull request as draft July 7, 2023 13:49
@quarkus-bot

This comment has been minimized.

Sign in to view
@mkouba mkouba force-pushed the recorder-context-javadoc branch from 32c8110 to cf1073c Compare July 10, 2023 08:08
@mkouba mkouba marked this pull request as ready for review July 10, 2023 08:10
@mkouba mkouba marked this pull request as draft July 10, 2023 08:10
@mkouba mkouba force-pushed the recorder-context-javadoc branch from cf1073c to 21b0571 Compare July 10, 2023 09:15
@mkouba mkouba requested a review from Ladicek July 10, 2023 09:15
@mkouba mkouba marked this pull request as ready for review July 10, 2023 09:15
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 10, 2023
@github-actions
Copy link

github-actions bot commented Jul 10, 2023 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@mkouba mkouba force-pushed the recorder-context-javadoc branch from 21b0571 to a63e2b8 Compare July 10, 2023 14:17
@mkouba mkouba requested a review from essobedo July 10, 2023 14:17
essobedo
essobedo approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@essobedo essobedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Awesome, thank you!

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 10, 2023

Failing Jobs - Building a63e2b8

Status Name Step Failures Logs Raw logs
✔️ Gradle Tests - JDK 11
✖ Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs
⌛ JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
⌛ JVM Tests - JDK 17 Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 19
✔️ Maven Tests - JDK 11
⌛ Maven Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.builder.QuarkusModelBuilderTest.shouldLoadMultiModuleTestModel line 66 - More details - Source on GitHub

org.gradle.tooling.BuildException: Could not run build action using connection to Gradle distribution 'https://services.gradle.org/distributions/gradle-8.1.1-bin.zip'.
	at org.gradle.tooling.internal.consumer.ExceptionTransformer.transform(ExceptionTransformer.java:51)
	at org.gradle.tooling.internal.consumer.ExceptionTransformer.transform(ExceptionTransformer.java:29)

✖ io.quarkus.gradle.builder.QuarkusModelBuilderTest.shouldLoadMultiModuleDevModel line 100 - More details - Source on GitHub

org.gradle.tooling.BuildException: Could not run build action using connection to Gradle distribution 'https://services.gradle.org/distributions/gradle-8.1.1-bin.zip'.
	at org.gradle.tooling.internal.consumer.ExceptionTransformer.transform(ExceptionTransformer.java:51)
	at org.gradle.tooling.internal.consumer.ExceptionTransformer.transform(ExceptionTransformer.java:29)

@mkouba mkouba merged commit 7dbd318 into quarkusio:main Jul 11, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 11, 2023
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@essobedo essobedo essobedo approved these changes

@Ladicek Ladicek Ladicek approved these changes

Assignees
No one assigned
Labels
area/core area/documentation
Projects
None yet
Milestone
3.3.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@mkouba @Ladicek @essobedo