Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Hibernate Search 6.2.0.Final #34602

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Conversation

yrodiere
Copy link
Member

@yrodiere yrodiere commented Jul 7, 2023

Changes since 6.2.0.CR1: https://hibernate.atlassian.net/issues/?jql=project=10061+AND+fixVersion=32168

There weren't many changes. Just a few micro dependency upgrades.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/hibernate-search Hibernate Search labels Jul 7, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 7, 2023

/cc @gsmet (hibernate-search)

@yrodiere yrodiere requested a review from gsmet July 7, 2023 15:15
@quarkus-bot

This comment has been minimized.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I need to restart CI as all the builds failed.

@Sanne
Copy link
Member

Sanne commented Jul 13, 2023

Rebased, not least to trigger another CI run

@quarkus-bot

This comment has been minimized.

@Sanne
Copy link
Member

Sanne commented Jul 14, 2023

It would seem none of the windows builds were able to complete. I can't say for sure but I haven't seen other recent PRs fail for a similar reason so it's a bit suspicious...

@marko-bekhta would you be able to have a better look?

@marko-bekhta
Copy link
Contributor

Ohh windows 😈 let me check what I can do 😃

@Sanne
Copy link
Member

Sanne commented Jul 14, 2023

@marko-bekhta thanks! But before digging deep, try to see if there were other PRs with the same issue - I don't know for sure if it's really the fault of this pr.

@marko-bekhta
Copy link
Contributor

But before digging deep

Ouch 😨😢 should've read that before installing windows 😆😆😆.

Just joking, I had a windows env but it didn't have quarkus on it so I've tried to build there -- but for some reason, it takes ages just to even run ./mvnw -Dquickly

From what I see the failed KotlinProjectWithCompilerArgsDevModeTest test is trying to do something with kotlin-grpc-project and there's nothing related to Search so I'd assume it is not related to the upgrade 😃

I see that a few neighbouring PRs have the timeouts on windows builds too...

There also don't seem to be any obvious changes in this release compared to CR1 that would cause any issues.

Maybe it's worth to try and restart the build once more? 🙈

@Sanne
Copy link
Member

Sanne commented Jul 14, 2023

great, thanks @marko-bekhta - I've now triggered a fresh build, let's see how it goes.

@quarkus-bot

This comment has been minimized.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 18, 2023
@gsmet
Copy link
Member

gsmet commented Jul 18, 2023

I rebased and force pushed to fix a conflict.

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 18, 2023

Failing Jobs - Building 69fe7f5

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 19
✔️ Maven Tests - JDK 11
Maven Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/vertx-http/deployment 
! Skipped: extensions/agroal/deployment extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 351 more

📦 extensions/vertx-http/deployment

io.quarkus.vertx.http.testrunner.tags.IncludeTagsTestCase.checkTestsAreRun line 52 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Failed to wait for test run 2 State{lastRun=1, running=true, inProgress=true, run=2, passed=2, failed=0, skipped=0, isBrokenOnly=false, isTestOutput=false, isInstrumentationBasedReload=false, isLiveReload=true}
	at io.quarkus.test.ContinuousTestingTestUtils.waitForNextCompletion(ContinuousTestingTestUtils.java:44)
	at io.quarkus.vertx.http.testrunner.tags.IncludeTagsTestCase.checkTestsAreRun(IncludeTagsTestCase.java:52)

@Sanne Sanne merged commit 583ea7a into quarkusio:main Jul 18, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 18, 2023
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Jul 18, 2023
@gsmet
Copy link
Member

gsmet commented Jul 20, 2023

I'm not entirely sure if @yrodiere wanted a backport so I will wait for him to come back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/hibernate-search Hibernate Search
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants