-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Hibernate Search 6.2.0.Final #34602
Conversation
/cc @gsmet (hibernate-search) |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I need to restart CI as all the builds failed.
Rebased, not least to trigger another CI run |
This comment has been minimized.
This comment has been minimized.
It would seem none of the windows builds were able to complete. I can't say for sure but I haven't seen other recent PRs fail for a similar reason so it's a bit suspicious... @marko-bekhta would you be able to have a better look? |
Ohh windows 😈 let me check what I can do 😃 |
@marko-bekhta thanks! But before digging deep, try to see if there were other PRs with the same issue - I don't know for sure if it's really the fault of this pr. |
Ouch 😨😢 should've read that before installing windows 😆😆😆. Just joking, I had a windows env but it didn't have quarkus on it so I've tried to build there -- but for some reason, it takes ages just to even run From what I see the failed I see that a few neighbouring PRs have the timeouts on windows builds too... There also don't seem to be any obvious changes in this release compared to CR1 that would cause any issues. Maybe it's worth to try and restart the build once more? 🙈 |
great, thanks @marko-bekhta - I've now triggered a fresh build, let's see how it goes. |
This comment has been minimized.
This comment has been minimized.
I rebased and force pushed to fix a conflict. |
Failing Jobs - Building 69fe7f5
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 17 Windows #- Failing: extensions/vertx-http/deployment
! Skipped: extensions/agroal/deployment extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 351 more 📦 extensions/vertx-http/deployment✖
|
I'm not entirely sure if @yrodiere wanted a backport so I will wait for him to come back. |
Changes since 6.2.0.CR1: https://hibernate.atlassian.net/issues/?jql=project=10061+AND+fixVersion=32168
There weren't many changes. Just a few micro dependency upgrades.