Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev UI: Migrate gRPC #34591

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Conversation

phillip-kruger
Copy link
Member

@phillip-kruger phillip-kruger commented Jul 7, 2023

Fix #32592

This migrates the Dev UI Screens and Tests for gRPC. We should consider to change this to let the Javascript hit the gRPC endpoint directly, rather than doing a json-rpc call that then does a Java gRPC Client call.

grpc

Signed-off-by: Phillip Kruger <[email protected]>
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@phillip-kruger phillip-kruger added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 7, 2023
@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 7, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@phillip-kruger phillip-kruger merged commit 0362e1c into quarkusio:main Jul 7, 2023
@quarkus-bot quarkus-bot bot added kind/enhancement New feature or request and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jul 7, 2023
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev UI: Migrate GRPC to the new Dev UI
2 participants