Implement XPending redis command #34519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RomainWilbert can you've a look at this? |
|
Great job ! I think this covers any xpending use case |
This comment has been minimized.
This comment has been minimized.
machi1990
requested changes
Jul 5, 2023
There was a problem hiding this comment.
the code change lgtm,thanks @cescoffier. I've however one question/suggestion. Let me know what you think @cescoffier
...c/main/java/io/quarkus/redis/runtime/datasource/ReactiveTransactionalStreamCommandsImpl.java
Outdated
Show resolved
Hide resolved
cescoffier
force-pushed
the
xpending-command
branch
from
950a7d1 to
41541cc
Compare
machi1990
reviewed
Jul 7, 2023
...lient/runtime/src/test/java/io/quarkus/redis/datasource/TransactionalStreamCommandsTest.java
Outdated
Show resolved
Hide resolved
machi1990
reviewed
Jul 7, 2023
...c/main/java/io/quarkus/redis/runtime/datasource/ReactiveTransactionalStreamCommandsImpl.java
Outdated
Show resolved
Hide resolved
machi1990
approved these changes
Jul 7, 2023
cescoffier
force-pushed
the
xpending-command
branch
from
41541cc to
d40c81c
Compare
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #34411.