-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow loading custom Groovy extension modules #34447
Allow loading custom Groovy extension modules #34447
Conversation
This comment has been minimized.
This comment has been minimized.
5920dc6
to
cf481c5
Compare
test-framework/common/src/main/java/io/quarkus/test/common/GroovyClassValue.java
Show resolved
Hide resolved
Interesting approach. Are you sure this avoids memory leaks? How did you test? |
Yes I'm sure I have tested it against my small project and the test project defined in #12498 with 30 tests instead 10 initially |
Actually, the problem is related to the ClassValue added to the JDK for languages like Groovy but they are very hard to clean up, the only way I know is the one described in this SO answer but in some use cases it can be too much and can have side effects |
cf481c5
to
786b44e
Compare
786b44e
to
752ec72
Compare
It looks like the CI is unstable because |
Another remark is about the duration of some Jobs that seem to be very long, I don't know if it is common or not? |
This comment has been minimized.
This comment has been minimized.
I see more or less the same results (duration + failing tests) in another PR #34417 |
Yeah, those seem to be flaky tests |
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
fixes #34446
Motivation
The custom Groovy extension modules cannot be detected from the System classloader
Modifications:
GroovyClassValue
to disable the usage ofClassValue
in GroovyGroovyCacheCleaner
as it is no more used