Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CIBA grant type to oidc-client #34357

Merged
merged 1 commit into from
Jul 2, 2023
Merged

Add CIBA grant type to oidc-client #34357

merged 1 commit into from
Jul 2, 2023

Conversation

Eng-Fouad
Copy link
Contributor

Fixes #34356

@geoand geoand requested a review from sberyozkin June 28, 2023 07:23
@sberyozkin sberyozkin marked this pull request as draft June 28, 2023 10:03
@sberyozkin
Copy link
Member

sberyozkin commented Jun 28, 2023 •
edited
Loading

Sorry @Eng-Fouad, I thought we should discuss an option of testing it given that all other grant types are tested AFAIK.
Can you have a look please at integration-tests/oidc-client-wiremock and see what can be done ?

@Eng-Fouad
Copy link
Contributor Author

Eng-Fouad commented Jun 28, 2023 •
edited
Loading

I have no much time atm. I will try to take a look on it next week.

@sberyozkin
Copy link
Member

@Eng-Fouad Sure, give a try please, I appreciate you opening a PR, I'll try to help with the test if you'll find it not easy to set up, but it should be mostly a copy and paste exercise - copy one of the wiremock stubs there and create the one for the CIBA grant, add one more oidc client tenant config with this grant and copy some test and use this tenant config.

@Eng-Fouad Eng-Fouad marked this pull request as ready for review July 1, 2023 13:35
@Eng-Fouad
Copy link
Contributor Author

Eng-Fouad commented Jul 1, 2023 •
edited
Loading

@sberyozkin Added test cases. Can you please verify if all tests pass? I couldn't compile the project properly on my machine.

@Eng-Fouad Eng-Fouad force-pushed the patch-1 branch 3 times, most recently from 8b64655 to df24021 Compare July 1, 2023 13:50
@github-actions
Copy link

github-actions bot commented Jul 1, 2023 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@quarkus-bot

This comment has been minimized.

Sign in to view
@sberyozkin
Copy link
Member

@Eng-Fouad Thanks, the test looks OK, have a look at
https://github.com/quarkusio/quarkus/blob/main/CONTRIBUTING.md#build

It should be very easy to build it, and then mvn clean install -Dtest=OidcClientTest#testCibaGrant in integration-tests/oidc-client-wiremock

@Eng-Fouad
Copy link
Contributor Author

@sberyozkin All tests should pass now.

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 2, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

sberyozkin
sberyozkin approved these changes Jul 2, 2023
View reviewed changes
Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effort @Eng-Fouad, thanks

@sberyozkin sberyozkin merged commit 7cc2cd7 into quarkusio:main Jul 2, 2023
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Jul 2, 2023
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Jul 2, 2023
@Eng-Fouad Eng-Fouad deleted the patch-1 branch July 2, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sberyozkin sberyozkin sberyozkin approved these changes

Assignees
No one assigned
Labels
area/documentation area/oidc kind/enhancement New feature or request
Projects
None yet
Milestone
3.3.0.CR1
Development

Successfully merging this pull request may close these issues.

Add CIBA grant type to oidc-client
2 participants
@Eng-Fouad @sberyozkin