-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize build runner in AwtProcessor before usage #34296
Initialize build runner in AwtProcessor before usage #34296
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
can you give some context of why you need it quiet? |
See this zulip discussion for details. The issue was already fixed in this PR. |
b0c6ac7
to
3614e84
Compare
797444d
to
f996e16
Compare
nativeImageRunnerBuildItem.getBuildRunner() | ||
.setup(processInheritIODisabled.isPresent() || processInheritIODisabledBuildItem.isPresent()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we have to do that, there is something wrong. I'll have to have a look later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I am misusing the setup(...)
method, but I can say that setup()
has not yet been called when AwtProcessor
is executed. Without the call to setup(...)
, the successive call to nativeImageRunnerBuildItem.getBuildRunner().getGraalVMVersion()
would trigger the initial image pull.
Seems that the docker version used in github-workflows has some kind of bug:
According to the documentation ( |
f996e16
to
f1cffe1
Compare
f1cffe1
to
b4e7c2d
Compare
@gsmet is this Pr still relevant, or can it be closed? |
b4e7c2d
to
d7eda21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what we are doing in AwtProcessor
is not really in line with what we should do. Or we should initialize things differently.
Let's merge your PR if CI passes but ideally I think we should rework this to avoid having all these quirks in the build steps.
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
No description provided.