Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QuarkusComponentTest: convenient way of mocking interceptors #34239

Merged
merged 3 commits into from
Jun 26, 2023
Merged

QuarkusComponentTest: convenient way of mocking interceptors #34239

merged 3 commits into from
Jun 26, 2023

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jun 22, 2023 •
edited
Loading

@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/testing labels Jun 22, 2023
@mkouba mkouba requested review from Ladicek and holly-cummins June 22, 2023 08:58
Ladicek
Ladicek approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I don't really like this way of declaring interceptors, but the code LGTM.

@mkouba mkouba force-pushed the componenttest-interceptor-methods branch from 3143e48 to d759d21 Compare June 22, 2023 12:05
@mkouba
Copy link
Contributor Author

mkouba commented Jun 22, 2023

To be honest, I don't really like this way of declaring interceptors, but the code LGTM.

I know, you told me already in #34086. That's why I was working on #34127 first.

@mkouba mkouba marked this pull request as ready for review June 22, 2023 12:45
@github-actions
Copy link

github-actions bot commented Jun 22, 2023 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 22, 2023

Failing Jobs - Building 6245f00

Status Name Step Failures Logs Raw logs
✔️ Maven Tests - JDK 11
⌛ Maven Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
⌛ Native Tests - Security1 Build ⚠️ Check → Logs Raw logs

@mkouba mkouba added this to the 3.3 - main milestone Jun 23, 2023
@mkouba mkouba merged commit 4c4623c into quarkusio:main Jun 26, 2023
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Jun 26, 2023
@mkouba mkouba mentioned this pull request Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladicek Ladicek Ladicek approved these changes

@holly-cummins holly-cummins Awaiting requested review from holly-cummins

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) area/documentation area/testing kind/enhancement New feature or request
Projects
None yet
Milestone
3.3.0.CR1
Development

Successfully merging this pull request may close these issues.

QuarkusComponentTest: offer a convenient way of mocking interceptors
2 participants
@mkouba @Ladicek