Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FindResourceWriters often creates HashSets and ArrayLists while not necessary #34209

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

franz1981
Copy link
Contributor

This is preventing to create to allocate memory of some common scenarios found while using Multi<T> in an endpoint, which involve streaming and perform this lookup (for T) for each element returned.

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 21, 2023

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@franz1981 franz1981 force-pushed the reduce_gc_find_writers branch from 5b87782 to 5f8c7f1 Compare June 29, 2023 14:03
@franz1981
Copy link
Contributor Author

@geoand this should be a minor but stil save allocations in the hot path if complex mutiny pipelines are used (involving Multi, which shouldn't be that common TBH)

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 29, 2023
@quarkus-bot

This comment has been minimized.

@geoand
Copy link
Contributor

geoand commented Jul 19, 2023

Can we fix this one and rebase it?

@franz1981 franz1981 force-pushed the reduce_gc_find_writers branch from 5f8c7f1 to e429604 Compare July 19, 2023 14:43
@franz1981 franz1981 changed the title findResourceWriters often creates HashSets and ArrayLists while not necessary FindResourceWriters often creates HashSets and ArrayLists while not necessary Jul 19, 2023
@quarkus-bot

This comment has been minimized.

@geoand
Copy link
Contributor

geoand commented Jul 19, 2023

Imports need need to be sorted

@franz1981 franz1981 force-pushed the reduce_gc_find_writers branch from e429604 to 5637402 Compare July 19, 2023 16:55
@franz1981 franz1981 force-pushed the reduce_gc_find_writers branch from 5637402 to ef07212 Compare July 19, 2023 20:37
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 20, 2023

Failing Jobs - Building ef07212

Status Name Step Failures Logs Raw logs
✔️ Gradle Tests - JDK 11
Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.devmode.ModuleWithParentDependencyDevModeTest.main line 14 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes  30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@geoand geoand merged commit ed2f2a8 into quarkusio:main Jul 20, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 20, 2023
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants