-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FindResourceWriters often creates HashSets and ArrayLists while not necessary #34209
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
5b87782
to
5f8c7f1
Compare
@geoand this should be a minor but stil save allocations in the hot path if complex mutiny pipelines are used (involving |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This comment has been minimized.
This comment has been minimized.
Can we fix this one and rebase it? |
5f8c7f1
to
e429604
Compare
This comment has been minimized.
This comment has been minimized.
Imports need need to be sorted |
e429604
to
5637402
Compare
5637402
to
ef07212
Compare
Failing Jobs - Building ef07212
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
|
This is preventing to create to allocate memory of some common scenarios found while using
Multi<T>
in an endpoint, which involve streaming and perform this lookup (for T) for each element returned.