Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix caching of properties #34082

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Conversation

maxandersen
Copy link
Member

fixes #33629 #33628 #33626

using append child to ensure it includes parent config too.

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 16, 2023

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@quarkus-bot

This comment has been minimized.

@maxandersen
Copy link
Member Author

Doh. Same bad syntax bug. Will fix when back.

@gsmet
Copy link
Member

gsmet commented Jun 16, 2023

@maxandersen pluginManagement needs to be nested inside build. I fixed it but... any chance you could test this before we merge?

@gsmet
Copy link
Member

gsmet commented Jun 16, 2023

BTW, I force pushed a fix already :)

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 16, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@maxandersen
Copy link
Member Author

any chance you could test this before we merge?

yeah, i tested it but hadn't committed the last changes. your push fixes it and now works afaics in local and ci. merging.

@maxandersen maxandersen merged commit b227b82 into quarkusio:main Jun 16, 2023
@quarkus-bot quarkus-bot bot added this to the 3.2 - main milestone Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rest-client-reactive tests has absolute path in application.properties
2 participants