Add support for project Java version update based on extensions #34065

ia3andy · 2023-06-15T15:15:22Z

Java version is now updated based on the extension metadata (min java version).

Gradle is not yet updating as we are still using OpenRewrite 7.x

part of #32392

ia3andy · 2023-06-15T15:17:46Z

cc @maxandersen @gsmet

ia3andy · 2023-06-15T15:23:14Z

Now we should decide:

should we first merge this
is it not to risky to put it in the next release
what should we start first (See TODO 👆)?

maxandersen · 2023-06-15T15:33:00Z

Non platform extensions version update auto generated

fixing this means we can removing https://github.com/quarkusio/quarkus-updates/blob/main/recipes/src/main/resources/quarkus-updates/core/3alpha.yaml#L30, right?

Fetch recipes from quarkus-updates for the extensions updates

This will be nice, but in theory its not an absolute blocker as long as the rules needed by i.e. camel can be added to the quarkus-updates. If we know of migrations that would be problematic that would change.

Update Java version based on min Java version

This is a minimal requirement for camel as they must update to java 17.

ia3andy · 2023-06-15T17:39:34Z

Non platform extensions version update auto generated

fixing this means we can removing https://github.com/quarkusio/quarkus-updates/blob/main/recipes/src/main/resources/quarkus-updates/core/3alpha.yaml#L30, right?

Yep

Fetch recipes from quarkus-updates for the extensions updates

This will be nice, but in theory its not an absolute blocker as long as the rules needed by i.e. camel can be added to the quarkus-updates. If we know of migrations that would be problematic that would change.

Update Java version based on min Java version

This is a minimal requirement for camel as they must update to java 17.

Ok, I've set the order in the TODO list

ia3andy · 2023-06-16T15:03:35Z

I added a new Commit to:

Clean the code related to Java version
Detect the version on Gradle and Maven project
Add the JavaVersion to the QuarkusProject
Warn if the project JavaVersion is not compatible with one or more of the udpated extensions

I haven't tested Gradle at all.

I've tested a Maven project in Quarkus 2.16 with Java 11 and the camel-core extension but currently the managed extensions are not in the ProjectExtensionsUpdateInfo so it requires some changes to include it in there so that extensionsUpdateInfo.getMinJavaVersion() also includes those extensions.

I've checked the data is here, we just need to put it in the UpdateInfo:

It might be also nice to display that they are going to be updated by the platform bom.

ia3andy · 2023-06-16T15:34:00Z

On Gradle we can use this: https://docs.openrewrite.org/recipes/gradle/changejavacompatibility
And on Maven we can update the properties, as maven.compiler.release is the one we use on generated project I would say we only set that one.

ia3andy · 2023-06-19T13:03:21Z

I've udpated the PR and the recipe to update the java version is now auto-generated.

For some reason the Gradle https://docs.openrewrite.org/recipes/gradle/updatejavacompatibility is not applied
This needs to be tested further

@gsmet @aloubyansky I leave this in your hand as tomorrow and Wednesday I might not be here much.

gsmet · 2023-06-20T13:06:31Z

I'll have a look after CR1. There are too many things that require my attention today.

ia3andy · 2023-06-28T09:32:04Z

The Gradle recipe is not applied because it's meant for OR 8.x, good news is that it doesn't break and the update java version log is displayed

quarkus-bot · 2023-06-28T17:30:56Z

Failing Jobs - Building `0d28057`

Status	Name	Step	Failures	Logs	Raw logs
✔️	Maven Tests - JDK 11
⌛	Maven Tests - JDK 11 Windows	`Build`	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - HTTP	`Build`	⚠️ Check →	Logs	Raw logs

ia3andy · 2023-06-29T06:04:31Z

@gsmet CI passed or not?

ia3andy · 2023-07-03T13:18:08Z

@gsmet up

gsmet · 2023-07-14T11:02:58Z

Sorry, I need to have a look at that.

gsmet

I tested this PR with and without a Camel extension and it seems to work OK.

I added a small stylistic comment but I think we should probably get this in and also backport it to 3.2.

gsmet · 2023-07-25T15:53:24Z

...nt-projects/tools/devtools-common/src/main/java/io/quarkus/devtools/project/JavaVersion.java

+    // ordering is important here, so let's keep them ordered
+    public static final SortedSet<Integer> JAVA_VERSIONS_LTS = new TreeSet<>(List.of(11, 17));
+    public static final int DEFAULT_JAVA_VERSION = 11;
+    public static final int MAX_LTS_SUPPORTED_BY_KOTLIN = 17;
+    public static final String DETECT_JAVA_RUNTIME_VERSION = "<<detect java runtime version>>";
+    public static final Pattern JAVA_VERSION_PATTERN = Pattern.compile("(\\d+)(?:\\..*)?");


Could we avoid having the constants in the middle of the class?

@ia3andy I will merge this for now but I would appreciate if you could give it some love when you're back. Thanks!

This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [flow-bin](https://github.com/flowtype/flow-bin) ([changelog](https://github.com/facebook/flow/blob/master/Changelog.md)) | devDependencies | minor | [`^0.214.0` -> `^0.215.0`](https://renovatebot.com/diffs/npm/flow-bin/0.214.0/0.215.1) | | [org.liquibase:liquibase-maven-plugin](http://www.liquibase.org/liquibase-maven-plugin) ([source](https://github.com/liquibase/liquibase)) | build | patch | `4.23.0` -> `4.23.1` | | [io.quarkus:quarkus-maven-plugin](https://github.com/quarkusio/quarkus) | build | minor | `3.2.3.Final` -> `3.3.0` | | [io.quarkus:quarkus-universe-bom](https://github.com/quarkusio/quarkus-platform) | import | minor | `3.2.3.Final` -> `3.3.0` | | [org.apache.maven.plugins:maven-enforcer-plugin](https://maven.apache.org/enforcer/) | build | minor | `3.3.0` -> `3.4.0` | --- ### Release Notes <details> <summary>flowtype/flow-bin</summary> ### [`v0.215.1`](flow/flow-bin@a92ce80...cbb038f) [Compare Source](flow/flow-bin@a92ce80...cbb038f) ### [`v0.215.0`](flow/flow-bin@ca11e28...a92ce80) [Compare Source](flow/flow-bin@ca11e28...a92ce80) </details> <details> <summary>liquibase/liquibase</summary> ### [`v4.23.1`](https://github.com/liquibase/liquibase/blob/HEAD/changelog.txt#Liquibase-4231-is-a-patch-release) [Compare Source](liquibase/liquibase@v4.23.0...v4.23.1) </details> <details> <summary>quarkusio/quarkus</summary> ### [`v3.3.0`](https://github.com/quarkusio/quarkus/releases/tag/3.3.0) [Compare Source](quarkusio/quarkus@3.2.4.Final...3.3.0) ##### Complete changelog - [#35350](quarkusio/quarkus#35350) - Fix package type system property clearing - [#35348](quarkusio/quarkus#35348) - quarkus-maven-plugin runs native building even if the profile is commented out - [#35343](quarkusio/quarkus#35343) - ArC: fix StackOverflowError in AutoAddScopeBuildItem - [#35319](quarkusio/quarkus#35319) - Register arrays of Hibernate ORM's JDBC basic types for reflection - [#35315](quarkusio/quarkus#35315) - Fix Datasource timing issues with Liquibase / Flyway and OpenTelemetry - [#35314](quarkusio/quarkus#35314) - Regression in 3.3.0.CR1: Synthetic bean instance for io.opentelemetry.api.OpenTelemetry not initialized yet - [#35312](quarkusio/quarkus#35312) - Updates Infinispan to 14.0.13.Final - [#35308](quarkusio/quarkus#35308) - Lock jib execution to avoid OverlappingFileLockException in parallel builds - [#35305](quarkusio/quarkus#35305) - Fix the titles of the tables in RESTEasy Reactive doc - [#35302](quarkusio/quarkus#35302) - Docs: Mention wilcard support in resteasy reactive XML serialisation exclude classes configuration - [#35301](quarkusio/quarkus#35301) - Fix potential NPE in quarkus-csrf-reactive when no MediaType is found - [#35299](quarkusio/quarkus#35299) - Output build graph using `quarkus.builder.graph-output` property - [#35285](quarkusio/quarkus#35285) - NullPointerException during http post request when quarkus-csrf-reactive extension is added to a project - [#35283](quarkusio/quarkus#35283) - Upgrade proto-google-common-protos to 2.23.0 - [#35282](quarkusio/quarkus#35282) - Avoid keeping references to BytecodeRecorderImpl - [#35276](quarkusio/quarkus#35276) - Reinstate DevModeTestUtil to avoid breaking other projects that depend on it - [#35273](quarkusio/quarkus#35273) - Fix small typo in comment - [#35263](quarkusio/quarkus#35263) - Stop the recovery service while ArC is still around - [#35245](quarkusio/quarkus#35245) - Add missing info to init Jobs - [#35244](quarkusio/quarkus#35244) - Init Jobs are missing ServiceAccount and Image Pull Secrets - [#35240](quarkusio/quarkus#35240) - Update SmallRye Health to 4.0.4 - [#34071](quarkusio/quarkus#34071) - 3.1.1 Final - java.lang.IllegalArgumentException: Class java.util.UUID\[] is instantiated reflectively but was never registered - [#32800](quarkusio/quarkus#32800) - Duplicated checks in health check response - [#11903](quarkusio/quarkus#11903) - Gradle multimodule project + quarkus-container-image-jib: OverlappingFileLockException ### [`v3.2.4.Final`](https://github.com/quarkusio/quarkus/releases/tag/3.2.4.Final) [Compare Source](quarkusio/quarkus@3.2.3.Final...3.2.4.Final) ##### Complete changelog - [#35300](quarkusio/quarkus#35300) - Fix `jandex-gradle-plugin-version` in CDI Reference - [#35296](quarkusio/quarkus#35296) - Upgrade H2 to 2.2.220 - [#35258](quarkusio/quarkus#35258) - CDI Reference 1.1 has incomplete information for gradle - [#35255](quarkusio/quarkus#35255) - Quartz: QuarkusMSSQLDelegate should extends MSSQLDelegate - [#35211](quarkusio/quarkus#35211) - Document Maven config options that may be relevant when running tests - [#35203](quarkusio/quarkus#35203) - Pass Maven user settings when initializing artifact resolver - [#35193](quarkusio/quarkus#35193) - OpenTelemetry service name should have higher priority than app name when no resource attributes are set - [#35189](quarkusio/quarkus#35189) - Quarkus CLI fixes - [#35188](quarkusio/quarkus#35188) - SmallRyeGraphQLOverWebSocketHandler: use order value > Integer.MIN_VALUE - [#35181](quarkusio/quarkus#35181) - REST Data with Panache should not produce links when hal is disabled - [#35174](quarkusio/quarkus#35174) - Ensure the narayana-jta extension fully shuts down the recovery manager - [#35172](quarkusio/quarkus#35172) - Kafka Streams: restore the feature name at Quarkus startup - [#35171](quarkusio/quarkus#35171) - kafka-streams: feature not listed on startup - [#35165](quarkusio/quarkus#35165) - Propagate all user methods in REST Data with Panache - [#35160](quarkusio/quarkus#35160) - Properly use internal links to point to other guides - [#35140](quarkusio/quarkus#35140) - ArC: fix deadlock when calling guarded methods on the same thread - [#35136](quarkusio/quarkus#35136) - Deadlock while calling write-locked method from read-locked method - [#34908](quarkusio/quarkus#34908) - `@RouteFilter` stopped working with WebSocket requests Quarkus 3.2.0.Final - [#34875](quarkusio/quarkus#34875) - Quarkus build does not work since 3.2.0 with teamcity/plexus launcher - [#34713](quarkusio/quarkus#34713) - Option to track build configuration for changes between builds - [#34576](quarkusio/quarkus#34576) - Live reload stopped working on 3.2 when using XA transactions - [#34514](quarkusio/quarkus#34514) - Support `@WithUnnamedKey` in documentation - [#34065](quarkusio/quarkus#34065) - Add support for project Java version update based on extensions - [#33317](quarkusio/quarkus#33317) - OpenTelemetry SDK autoconfiguration ignores OTEL service name in favor of Quarkus app name - [#15461](quarkusio/quarkus#15461) - Quarkus tests fails mTLS authentication against internal Maven repository </details> <details> <summary>quarkusio/quarkus-platform</summary> ### [`v3.3.0`](quarkusio/quarkus-platform@3.2.4.Final...3.3.0) [Compare Source](quarkusio/quarkus-platform@3.2.4.Final...3.3.0) ### [`v3.2.4.Final`](quarkusio/quarkus-platform@3.2.3.Final...3.2.4.Final) [Compare Source](quarkusio/quarkus-platform@3.2.3.Final...3.2.4.Final) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This MR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [x] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

…s-googlecloud-jsonlogging!17) This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.quarkus:quarkus-extension-processor](https://github.com/quarkusio/quarkus) | | minor | `3.2.3.Final` -> `3.3.0` | | [io.quarkus:quarkus-extension-maven-plugin](https://github.com/quarkusio/quarkus) | build | minor | `3.2.3.Final` -> `3.3.0` | | [io.quarkus:quarkus-maven-plugin](https://github.com/quarkusio/quarkus) | build | minor | `3.2.3.Final` -> `3.3.0` | | [io.quarkus:quarkus-bom](https://github.com/quarkusio/quarkus) | import | minor | `3.2.3.Final` -> `3.3.0` | --- ### Release Notes <details> <summary>quarkusio/quarkus</summary> ### [`v3.3.0`](quarkusio/quarkus@3.2.4.Final...3.3.0) [Compare Source](quarkusio/quarkus@3.2.4.Final...3.3.0) ### [`v3.2.4.Final`](https://github.com/quarkusio/quarkus/releases/tag/3.2.4.Final) [Compare Source](quarkusio/quarkus@3.2.3.Final...3.2.4.Final) ##### Complete changelog - [#35300](quarkusio/quarkus#35300) - Fix `jandex-gradle-plugin-version` in CDI Reference - [#35296](quarkusio/quarkus#35296) - Upgrade H2 to 2.2.220 - [#35258](quarkusio/quarkus#35258) - CDI Reference 1.1 has incomplete information for gradle - [#35255](quarkusio/quarkus#35255) - Quartz: QuarkusMSSQLDelegate should extends MSSQLDelegate - [#35211](quarkusio/quarkus#35211) - Document Maven config options that may be relevant when running tests - [#35203](quarkusio/quarkus#35203) - Pass Maven user settings when initializing artifact resolver - [#35193](quarkusio/quarkus#35193) - OpenTelemetry service name should have higher priority than app name when no resource attributes are set - [#35189](quarkusio/quarkus#35189) - Quarkus CLI fixes - [#35188](quarkusio/quarkus#35188) - SmallRyeGraphQLOverWebSocketHandler: use order value > Integer.MIN_VALUE - [#35181](quarkusio/quarkus#35181) - REST Data with Panache should not produce links when hal is disabled - [#35174](quarkusio/quarkus#35174) - Ensure the narayana-jta extension fully shuts down the recovery manager - [#35172](quarkusio/quarkus#35172) - Kafka Streams: restore the feature name at Quarkus startup - [#35171](quarkusio/quarkus#35171) - kafka-streams: feature not listed on startup - [#35165](quarkusio/quarkus#35165) - Propagate all user methods in REST Data with Panache - [#35160](quarkusio/quarkus#35160) - Properly use internal links to point to other guides - [#35140](quarkusio/quarkus#35140) - ArC: fix deadlock when calling guarded methods on the same thread - [#35136](quarkusio/quarkus#35136) - Deadlock while calling write-locked method from read-locked method - [#34908](quarkusio/quarkus#34908) - `@RouteFilter` stopped working with WebSocket requests Quarkus 3.2.0.Final - [#34875](quarkusio/quarkus#34875) - Quarkus build does not work since 3.2.0 with teamcity/plexus launcher - [#34713](quarkusio/quarkus#34713) - Option to track build configuration for changes between builds - [#34576](quarkusio/quarkus#34576) - Live reload stopped working on 3.2 when using XA transactions - [#34514](quarkusio/quarkus#34514) - Support `@WithUnnamedKey` in documentation - [#34065](quarkusio/quarkus#34065) - Add support for project Java version update based on extensions - [#33317](quarkusio/quarkus#33317) - OpenTelemetry SDK autoconfiguration ignores OTEL service name in favor of Quarkus app name - [#15461](quarkusio/quarkus#15461) - Quarkus tests fails mTLS authentication against internal Maven repository </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Jun 15, 2023

ia3andy requested a review from aloubyansky June 15, 2023 15:17

ia3andy mentioned this pull request Jun 15, 2023

Fetch recipes from quarkus-updates for the non-core extensions updates ia3andy/tasks#16

Closed

quarkus-bot bot added area/cli Related to quarkus cli (not maven/gradle/etc.) area/gradle Gradle area/jbang Issues related to when using jbang.dev with Quarkus area/maven labels Jun 16, 2023

ia3andy changed the title ~~Extract update info as data structures~~ Extract update info as data structures and update java version Jun 19, 2023

gsmet added the triage/backport? label Jun 27, 2023

ia3andy force-pushed the update-info branch from b32ddb3 to 8f9faca Compare June 28, 2023 09:21

ia3andy added 2 commits June 28, 2023 11:23

Extract update info as data structures

e9006c1

Check for min java version when updating (partial)

848a6f2

ia3andy force-pushed the update-info branch from 8f9faca to 35f9368 Compare June 28, 2023 09:23

ia3andy marked this pull request as ready for review June 28, 2023 09:31

This comment has been minimized.

Sign in to view

Update java version from recipe

0d28057

ia3andy force-pushed the update-info branch from 35f9368 to 0d28057 Compare June 28, 2023 11:01

ia3andy changed the title ~~Extract update info as data structures and update java version~~ Add support for project Java version update based on extensions Jun 28, 2023

ia3andy mentioned this pull request Jun 28, 2023

Add support for project Java version update based on extensions ia3andy/tasks#21

Closed

gsmet self-assigned this Jul 14, 2023

gsmet reviewed Jul 25, 2023

View reviewed changes

aloubyansky approved these changes Aug 1, 2023

View reviewed changes

gsmet approved these changes Aug 3, 2023

View reviewed changes

gsmet merged commit 7a72b87 into quarkusio:main Aug 3, 2023

quarkus-bot bot added this to the 3.3 - main milestone Aug 3, 2023

gsmet added the triage/backport-3.2 label Aug 9, 2023

gsmet modified the milestones: 3.3.0.CR1, 3.2.4.Final Aug 9, 2023

gsmet removed triage/backport-3.2 triage/backport? labels Aug 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for project Java version update based on extensions #34065

Add support for project Java version update based on extensions #34065

ia3andy commented Jun 15, 2023 •

edited

Loading

ia3andy commented Jun 15, 2023

ia3andy commented Jun 15, 2023 •

edited

Loading

maxandersen commented Jun 15, 2023

ia3andy commented Jun 15, 2023

ia3andy commented Jun 16, 2023

ia3andy commented Jun 16, 2023

ia3andy commented Jun 19, 2023

gsmet commented Jun 20, 2023

ia3andy commented Jun 28, 2023

This comment has been minimized.

quarkus-bot bot commented Jun 28, 2023

ia3andy commented Jun 29, 2023

ia3andy commented Jul 3, 2023

gsmet commented Jul 14, 2023

gsmet left a comment

gsmet Jul 25, 2023

gsmet Aug 3, 2023

Add support for project Java version update based on extensions #34065

Add support for project Java version update based on extensions #34065

Conversation

ia3andy commented Jun 15, 2023 • edited Loading

ia3andy commented Jun 15, 2023

ia3andy commented Jun 15, 2023 • edited Loading

maxandersen commented Jun 15, 2023

ia3andy commented Jun 15, 2023

ia3andy commented Jun 16, 2023

ia3andy commented Jun 16, 2023

ia3andy commented Jun 19, 2023

gsmet commented Jun 20, 2023

ia3andy commented Jun 28, 2023

This comment has been minimized.

quarkus-bot bot commented Jun 28, 2023

Failing Jobs - Building 0d28057

ia3andy commented Jun 29, 2023

ia3andy commented Jul 3, 2023

gsmet commented Jul 14, 2023

gsmet left a comment

Choose a reason for hiding this comment

gsmet Jul 25, 2023

Choose a reason for hiding this comment

gsmet Aug 3, 2023

Choose a reason for hiding this comment

ia3andy commented Jun 15, 2023 •

edited

Loading

ia3andy commented Jun 15, 2023 •

edited

Loading

Failing Jobs - Building `0d28057`