Only invoke public no args callbacks in Arquillian testing #34031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
gastaldi
approved these changes
Jun 16, 2023
gastaldi
reviewed
Jun 16, 2023
| @@ -23,7 +23,9 @@ static void invokeJunitBefores(String className, Object testInstance) | |||
| collectCallbacks(testInstance.getClass(), befores, (Class<? extends Annotation>) testInstance.getClass() | |||
| .getClassLoader().loadClass(className)); | |||
| for (Method before : befores) { | |||
| before.invoke(testInstance); | |||
| if (before.canAccess(testInstance) && before.getParameters().length == 0) { | |||
There was a problem hiding this comment.
I wonder if we shouldn't log why Before and After methods were not invoked when this returns false
There was a problem hiding this comment.
Yes, this is not ideal, but it is just an easy fix to run the JAX-RS TCK. Annotated methods can declare parameters resolvable by JUnit ParameterResolvers.. In such cases, we will fail. This fix will ignore such methods, but we need a more permanent solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.