ArC: prevent removing the final flag from records #33882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would have added a test, but I don't think we have a good place for that. We could add |
mkouba
approved these changes
Jun 7, 2023
This comment has been minimized.
This comment has been minimized.
|
I'll try adding the |
manovotn
approved these changes
Jun 8, 2023
Record classes must always be `final`, even the `Class.isRecord()` method checks that. Therefore, the bytecode transformation that removes the `final` flag from a class is invalid for records. With this commit, ArC will no longer blindly remove the `final` flag from records; a deployment problem occurs instead. This means that records cannot be used to define normal scoped beans and cannot be intercepted or decorated.
Ladicek
force-pushed
the
prevent-removing-final-from-records
branch
from
d3179dc to
540b809
Compare
|
Done, tests are in the 2nd commit. |
manovotn
added
the
triage/waiting-for-ci
This comment has been minimized.
This comment has been minimized.
Failing Jobs - Building 540b809
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 19 #- Failing: extensions/amazon-lambda/deployment
! Skipped: extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment integration-tests/amazon-lambda and 6 more📦 extensions/amazon-lambda/deployment✖ |
|
|
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record classes must always be
final, even theClass.isRecord()method checks that. Therefore, the bytecode transformation that removes thefinalflag from a class is invalid for records.With this commit, ArC will no longer blindly remove the
finalflag from records; a deployment problem occurs instead. This means that records cannot be used to define normal scoped beans and cannot be intercepted or decorated.Fixes #33810