-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce an attribute for the platform groupId #33745
Introduce an attribute for the platform groupId #33745
Conversation
🙈 The PR is closed and the preview is expired. |
I am trying to facilitate incremental improvement by not spamming the universe with all of the errors (especially for errors related to docs you didn't touch). We can trigger analysis of everything (it's a change in parameter when you invoke the test), but I think that's an activity for a different PR.
I should/could capture this error level in the docs build and make it a build annotation? That was my mistake originally, and a bunch of humans (including me) missed it the first few times around.. |
@inoxx03 @michelle-purcell I let you check it's all good for you on the doc side and that it does what you wanted? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Many thanks for implementing this change @gsmet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @inoxx03 here you go for what you requested.
@ebullient I'm a bit concerned by the first commit: your metadata checking tool reported some errors but apparently only because I modified the file. I think we should at least run it on all the files that are around once to fix the failures. And maybe we should also trigger a full run when it is modified.
@inoxx03 the second commit concerns me a bit. It's not the first time that I fix a formatting error that goes unnoticed for a long while. At least from time to time, the doc team should have a look at the output of the Maven doc build as some errors are unfortunately logged at debug level and are not triggering a build failure.