Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump guava from 31.1-jre to 32.0.0-jre #33684

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 29, 2023

Bumps guava from 31.1-jre to 32.0.0-jre.

Release notes

Sourced from guava's releases.

32.0.0

Maven

<dependency>
  <groupId>com.google.guava</groupId>
  <artifactId>guava</artifactId>
  <version>32.0.0-jre</version>
  <!-- or, for Android: -->
  <version>32.0.0-android</version>
</dependency>

Jar files

Guava requires one runtime dependency, which you can download here:

Javadoc

JDiff

Changelog

Security fixes

While CVE-2020-8908 was officially closed when we deprecated Files.createTempDir in Guava 30.0, we've heard from users that even recent versions of Guava have been listed as vulnerable in other databases of security vulnerabilities. In response, we've reimplemented the method (and the very rarely used FileBackedOutputStream class, which had a similar issue) to eliminate the insecure behavior entirely. This change technically carries small risks (dicussed under "Incompatible changes" below), but we expect no practical risk to users.

Incompatible changes

Although this release bumps Guava's major version number, it makes no binary-incompatible changes to the guava artifact. Still, it makes a few changes that may cause problems for users in less common situations:

  • This release makes a binary-incompatible change to a @Beta API in the separate artifact guava-testlib. Specifically, we changed the return type of TestingExecutors.sameThreadScheduledExecutor to ListeningScheduledExecutorService. The old return type was a package-private class, which caused the Kotlin compiler to produce warnings. (dafaa3e435)
  • This release adds two methods to the Android flavor of Guava: Invokable.getAnnotatedReturnType() and Parameter.getAnnotatedType(). Those methods do not work under an Android VM; we added them only to help our tests of the Android flavor (since we also run those tests under a JRE). Android VMs tolerate such methods as long as the app does not call them or perform reflection on them, and builds tolerate them because of our new Proguard configurations (discussed below). Thus, we expect no impact to most users. However, we could imagine build problems for users who have set up their own build system for the Android flavor of Guava. Please report any problems so that we can judge how safely we might be able to add other methods to the Android flavor in the future, such as APIs that use Java 8 classes like Stream. (b30e73cfa81ad15c1023c17cfd083255a3df0105)
  • This release removes various APIs from the guava-gwt. This affects only users of GWT. The APIs we removed are Enums, Sets.complementOf, and the Enum*BiMap classes' keyType() and valueType() methods. These changes prepare for the removal of reflective enum-related APIs from J2CL. If one of these changes causes you problems as a GWT user, let us know. (c3a155dc85, 09db2c29ae, 3de12be516)
  • The new implementations of Files.createTempDir and FileBackedOutputStream are annotated as @J2ObjCIncompatible. If you need to use them under J2ObjC, contact us. (56dc928a25)
  • Because the new version of Files.createTempDir restricts permissions to the current user, it could break any user that relies on letting other users access the directory.

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the area/dependencies Pull requests that update a dependency file label May 29, 2023
@quarkus-bot quarkus-bot bot added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label May 29, 2023
@quarkus-bot

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Jun 6, 2023

@gastaldi do you have some cycles to look at what needs to be fixed for this one (or if we prefer skipping it)? If not, I'll do it later this week.

@gastaldi
Copy link
Contributor

gastaldi commented Jun 6, 2023

@gsmet I see these errors when building:

[ERROR]
Dependency convergence error for com.google.j2objc:j2objc-annotations:jar:2.8 paths to dependency are:
+-io.quarkus:quarkus-grpc-codegen:jar:999-SNAPSHOT
  +-com.google.protobuf:protobuf-java-util:jar:3.22.0:compile
    +-com.google.guava:guava:jar:32.0.0-jre:compile
      +-com.google.j2objc:j2objc-annotations:jar:2.8:compile
and
+-io.quarkus:quarkus-grpc-codegen:jar:999-SNAPSHOT
  +-com.google.protobuf:protobuf-java-util:jar:3.22.0:compile
    +-com.google.j2objc:j2objc-annotations:jar:1.3:compile

For some reason fixing the com.google.j2objc:j2objc-annotations version in the bootstrap BOM does not help. Appreciate any pointers.

@gastaldi
Copy link
Contributor

gastaldi commented Jun 6, 2023

Ah wait, I might have forgotten to build the application/bom. It seems to work now. Updating PR now

Bumps [guava](https://github.com/google/guava) from 31.1-jre to 32.0.0-jre.
- [Release notes](https://github.com/google/guava/releases)
- [Commits](https://github.com/google/guava/commits)

---
updated-dependencies:
- dependency-name: com.google.guava:guava
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-Authored-by: George Gastaldi <[email protected]>
@gastaldi gastaldi force-pushed the dependabot/maven/com.google.guava-guava-32.0.0-jre branch from 8ea1327 to 5c4894e Compare June 6, 2023 20:11
@gastaldi gastaldi requested a review from gsmet June 6, 2023 20:11
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 7, 2023

Failing Jobs - Building 5c4894e

Status Name Step Failures Logs Raw logs
✔️ Maven Tests - JDK 11
Maven Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
Native Tests - Amazon Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Native Tests - Amazon #

- Failing: integration-tests/amazon-lambda integration-tests/amazon-lambda-http 

📦 integration-tests/amazon-lambda

io.quarkus.it.amazon.lambda.AmazonLambdaSimpleIT.testSimpleLambdaSuccess - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.amazon.lambda.deployment.DevServicesLambdaProcessor#startEventServer threw an exception: java.lang.RuntimeException: java.util.concurrent.ExecutionException: java.net.BindException: Address already in use

📦 integration-tests/amazon-lambda-http

io.quarkus.it.amazon.lambda.AmazonLambdaSimpleIT.testJaxrsCognitoJWTSecurityContext - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.amazon.lambda.deployment.DevServicesLambdaProcessor#startEventServer threw an exception: java.lang.RuntimeException: java.util.concurrent.ExecutionException: java.net.BindException: Address already in use

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 9, 2023

A newer version of com.google.guava:guava exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gsmet gsmet merged commit d405788 into main Jun 15, 2023
@quarkus-bot quarkus-bot bot added this to the 3.2 - main milestone Jun 15, 2023
@dependabot dependabot bot deleted the dependabot/maven/com.google.guava-guava-32.0.0-jre branch June 15, 2023 13:02
@gsmet gsmet modified the milestones: 3.2.0.CR1, 2.13.9.Final Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins kind/component-upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants